Skip to content

Cherry Pick Fix Refresh Token Rotation. (#2884)#2886

Merged
brandonpage merged 1 commit into
forcedotcom:masterfrom
brandonpage:cherry-pick/refresh-token-rotation
May 15, 2026
Merged

Cherry Pick Fix Refresh Token Rotation. (#2884)#2886
brandonpage merged 1 commit into
forcedotcom:masterfrom
brandonpage:cherry-pick/refresh-token-rotation

Conversation

@brandonpage
Copy link
Copy Markdown
Contributor

  • Fix Refresh Token Rotation.

  • Update UserAccount.getRefreshToken to always return the latest values known to the SDK. Add getRefreshTokenForPersistance to handle account updates and storage.

* Fix Refresh Token Rotation.

* Update UserAccount.getRefreshToken to always return the latest values known to the SDK.  Add getRefreshTokenForPersistance to handle account updates and storage.
@github-actions
Copy link
Copy Markdown

1 Error
🚫 Please re-submit this PR to the dev branch, we may have already fixed your issue.

Generated by 🚫 Danger

@github-actions
Copy link
Copy Markdown

1 Warning
⚠️ libs/SalesforceSDK/src/com/salesforce/androidsdk/accounts/UserAccountManager.java#L109 - Do not place Android context classes in static fields (static reference to UserAccountManager which has field context pointing to Context); this is a memory leak

Generated by 🚫 Danger

@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

❌ Patch coverage is 78.57143% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.98%. Comparing base (b8308bd) to head (fb064ed).
⚠️ Report is 165 commits behind head on master.

Files with missing lines Patch % Lines
...om/salesforce/androidsdk/accounts/UserAccount.java 77.77% 1 Missing and 3 partials ⚠️
...sforce/androidsdk/accounts/UserAccountManager.java 80.00% 0 Missing and 1 partial ⚠️
.../com/salesforce/androidsdk/rest/ClientManager.java 50.00% 0 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (78.57%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2886      +/-   ##
============================================
+ Coverage     55.33%   64.98%   +9.64%     
- Complexity     2443     2985     +542     
============================================
  Files           211      222      +11     
  Lines         17223    17500     +277     
  Branches       2403     2501      +98     
============================================
+ Hits           9531    11373    +1842     
+ Misses         6649     4909    -1740     
- Partials       1043     1218     +175     
Components Coverage Δ
Analytics 47.92% <ø> (ø)
SalesforceSDK 59.94% <82.21%> (+16.13%) ⬆️
Hybrid 59.05% <100.00%> (+1.08%) ⬆️
SmartStore 78.20% <ø> (ø)
MobileSync 81.68% <ø> (+6.50%) ⬆️
React 52.36% <ø> (+5.41%) ⬆️
Files with missing lines Coverage Δ
...esforce/androidsdk/auth/AuthenticationUtilities.kt 54.92% <100.00%> (+54.92%) ⬆️
...sforce/androidsdk/accounts/UserAccountManager.java 74.84% <80.00%> (+3.92%) ⬆️
.../com/salesforce/androidsdk/rest/ClientManager.java 63.21% <50.00%> (+31.40%) ⬆️
...om/salesforce/androidsdk/accounts/UserAccount.java 81.81% <77.77%> (+1.27%) ⬆️

... and 102 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@brandonpage
Copy link
Copy Markdown
Contributor Author

I pulled in the one box Login screen changes to our AuthFlowTester tests from dev and all pass locally.

@brandonpage brandonpage merged commit 8b1c404 into forcedotcom:master May 15, 2026
14 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants