UIREQ-1363: Fix Year field to correctly parse and display multiple years

[Dmitriy-Litvinenko]

Purpose

Fix Year field to correctly parse and display multiple years

Refs

https://folio-org.atlassian.net/browse/UIREQ-1363

[github-actions]

Jest Unit Test Results

    1 files  ±0     66 suites  ±0   1m 42s ⏱️ +2s
  889 tests ±0    889 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 251 runs  ±0  1 251 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 1cbde07. ± Comparison against base commit 7c70b4c.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[zburke]

This is the right fix for the wrong problem. It is the right fix because it does what the ticket asks (fine, approved) but this change doubles down on an undocumented convention for supplying structured data in a free-text field. Is the PO aware of this glaring inadequacy? There is no front-end validation for this structured data. Did you file a follow-up bug? There is no back-end validation for this structured data. Did you file a follow-up bug?

Secondly, "fix year field" does not describe the problem or how this change solves it. Don't make me read your code to figure out what is happening and why.

This would have been a great opportunity to add some documentation to getFormattedYears(). What is the shape of the arguments going in and the string coming out?