STRWEB-158 Exclude consumer test files from type checking - #189
Merged
Conversation
|
zburke
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



https://folio-org.atlassian.net/browse/STRWEB-158
Purpose
webpack/tsconfig.jsonextendsincludefour levels up (../../../../src/**/*.ts(x)) to cover a consuming project's source tree, butexcludeis not extended to the same depth. As a result, consumer test files undersrc/(e.g.src/components/Foo/Foo.test.tsx) are pulled into the type-check program created byfork-ts-checker-webpack-plugin. A type-only issue in such a file blocksstripes build, even though the consumer's owntscmay pass. Test files are not part of the production bundle, so including them in the build's type-check program adds little value while creating friction. Excluding them keeps responsibilities cleanly separated betweenstripes buildand the consumer's owntsc --noEmit/yarn test.Approach
Add
../../../../src/**/*.test.tsand../../../../src/**/*.test.tsxto theexcludelist inwebpack/tsconfig.jsonto match the depth of the existingincludepatterns.