STRWEB-157 change react to react-jsx in tsconfig.json - #167
Conversation
…import React from 'react'` at the top of all `.tsx` files We should also look into changing moduleResolution, as `node` appears to be an alias for node10, designed for use with versions of Node <= 10 However changing this ALSO requires a change to the `module` configuration, and changes there seemed to brick ui-mosaic-settings, so I have left alone for now
ncovercash
changed the title
react to react--jsx in tsconfig.json to avoid unnecessary import React from 'react'react to react-jsx in tsconfig.json to avoid unnecessary import React from 'react'
|
@SerhiiNosko This change has been tested in platform-complete without |
|
zburke
left a comment
zburke
left a comment
There was a problem hiding this comment.
Yes! Please! Why didn't we merge this a year ago?!?
|
@zburke Because I wasn't able to confirm that it didn't break all configurations of platform complete, IIRC ui-claims was causing some difficulties :( |
|
|
@ncovercash @zburke @SerhiiNosko Bumping this - the
Outstanding issues in
None of these are caused by this PR, and none get worse under We'd love to see this finally get merged. |
zburke
changed the title
react to react-jsx in tsconfig.json to avoid unnecessary import React from 'react'react to react-jsx in tsconfig.json
|
@EthanFreestone, @alb3rtino, I moved this from "Draft" to "Open" based on your assertion that issues in ui-claims are unrelated. Consider posting on Slack#folio-stripes-updates before/when you merge to raise awareness of the change. If there are unexpected side-effects in other repositories, that will provide a clue to their owners about what changed and (hopefully) speed up troubleshooting. FTR, I am able to build platform-lsp#snapshot, which includes As Noah noted in the Slack conversation Ethan points to in the description, the build scripts in stripes-webpack are chock full of anti-patterns that no doubt made sense at the time, but a lot has changed since those scripts were first written circa 2017 and every FOLIO UI dev was deeply familiar with every folio-org UI repository. We welcome advice and assistance on making targeted changes like this one, and on the larger project of improving how builds work at the repository, workspace, and platform levels. CC: @ncovercash, @SerhiiNosko |
|
|
Thank you all @zburke @ncovercash @alb3rtino , it's been a long track but it's finally in! 😄 |
5 participants
build: Change jsx configuration to
react-jsxto avoid unnecessaryimport React from 'react'at the top of all.tsxfilesWe should also look into changing moduleResolution, asnodeappears to be an alias for node10, designed for use with versions of Node <= 10However changing this ALSO requires a change to themoduleconfiguration, and changes there seemed to brick ui-mosaic-settings, so I have left alone for nowSee https://stackoverflow.com/questions/71463698/why-we-need-nodenext-typescript-compiler-option-when-we-have-esnext and @ncovercash comments on thread: https://open-libr-foundation.slack.com/archives/CAN13SWBF/p1755094505685999?thread_ts=1755084794.784919&cid=CAN13SWBF
Seems like the current confiig is quite possibly the best for what we're doing right now as far as moduleResolution is concerned