Conversation
Upgrade `postcss` to `v8` for compatibility with `webpack` `v5`. Upgrade supporting `postcss-*` libs too of course. Refs STCOM-892
Member
Author
|
@JohnC-80, I updated storybook packages and config for webpack 5 and things now compile 🎉 But, many stories barf with an error referencing Icon: You can git checkout this branch then apply the following patch to package.json to get the corresponding branches in |
Baroquem
approved these changes
Oct 28, 2021
JohnC-80
approved these changes
Nov 2, 2021
JohnC-80
left a comment
Contributor
There was a problem hiding this comment.
The build speed improvement is 🔥 🔥 🔥 Great work, guys!
|
Kudos, SonarCloud Quality Gate passed! |
Merged
JohnC-80
added a commit
that referenced
this pull request
Dec 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Upgrade
postcsstov8for compatibility withwebpackv5. Upgradesupporting
postcss-*libs too of course.See also:
Refs STCOM-892, STRWEB-4