Skip to content

STCOM-892 upgrade postcss to v8, webpack to v5 - #1642

Merged
zburke merged 6 commits into
masterfrom
STCOM-892
Nov 5, 2021
Merged

STCOM-892 upgrade postcss to v8, webpack to v5#1642
zburke merged 6 commits into
masterfrom
STCOM-892

Conversation

@zburke

@zburke zburke commented Oct 28, 2021

Copy link
Copy Markdown
Member

Upgrade postcss to v8 for compatibility with webpack v5. Upgrade
supporting postcss-* libs too of course.

See also:

Refs STCOM-892, STRWEB-4

Upgrade `postcss` to `v8` for compatibility with `webpack` `v5`. Upgrade
supporting `postcss-*` libs too of course.

Refs STCOM-892
@github-actions

github-actions Bot commented Oct 28, 2021

Copy link
Copy Markdown

Jest Unit Test Statistics

0 files  ±0  0 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 6c3aedd. ± Comparison against base commit b3b9cb9.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Oct 28, 2021

Copy link
Copy Markdown

BigTest Unit Test Statistics

0 files   -        1  0 suites   - 1   0s ⏱️ -2s
0 tests  - 1 181  0 ✔️  - 1 176  0 💤  - 5  0 ±0 
0 runs   - 1 183  0 ✔️  - 1 178  0 💤  - 5  0 ±0 

Results for commit 6c3aedd. ± Comparison against base commit b3b9cb9.

♻️ This comment has been updated with latest results.

@zburke

zburke commented Oct 28, 2021

Copy link
Copy Markdown
Member Author

@JohnC-80, I updated storybook packages and config for webpack 5 and things now compile 🎉 But, many stories barf with an error referencing Icon:

Error: Element type is invalid: expected a string (for built-in components) 
or a class/function (for composite components) but got: undefined. You 
likely forgot to export your component from the file it's defined in, or you 
might have mixed up default and named imports.

Check the render method of `Icon`.

at createFiberFromTypeAndProps (http://localhost:9001/vendors-node_modules_storybook_addon-actions_dist_esm_index_js-node_modules_storybook_core-cl-fd9c71.iframe.bundle.js:251942:21)
...

You can git checkout this branch then apply the following patch to package.json to get the corresponding branches in stripes-cli and stripes-webpack:

diff --git a/package.json b/package.json
index 7e8af366..bce955c4 100644
--- a/package.json
+++ b/package.json
@@ -47,7 +47,7 @@
     "@bigtest/interactor": "0.7.2",
     "@bigtest/mocha": "^0.5.0",
     "@folio/eslint-config-stripes": "^6",
-    "@folio/stripes-cli": "^2.4.0",
+    "@folio/stripes-cli": "folio-org/stripes-cli#STCLI-187",
     "@folio/stripes-testing": "^4.0.0",
     "@mdx-js/loader": "^1.6.22",
     "@storybook/addon-actions": "^6.3.6",
@@ -133,6 +133,7 @@
     "react-router-dom": "^5.2.0"
   },
   "resolutions": {
-    "moment": "~2.24.0"
+    "moment": "~2.24.0",
+    "@folio/stripes-webpack": "folio-org/stripes-webpack#STRWEB-4"
   }
 }

@mkuklis mkuklis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zburke you are on fire today! Nice work! 🎉

@JohnC-80 JohnC-80 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build speed improvement is 🔥 🔥 🔥 Great work, guys!

@sonarqubecloud

sonarqubecloud Bot commented Nov 5, 2021

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@zburke
zburke merged commit ddaff22 into master Nov 5, 2021
@zburke
zburke deleted the STCOM-892 branch November 5, 2021 02:17
mkuklis added a commit that referenced this pull request Nov 5, 2021
@mkuklis mkuklis mentioned this pull request Nov 5, 2021
@zburke
zburke restored the STCOM-892 branch November 7, 2021 11:44
mkuklis added a commit that referenced this pull request Dec 7, 2021
JohnC-80 added a commit that referenced this pull request Dec 15, 2021
…"" (#1680)

This reverts commit 6f4ac75.

Co-authored-by: John Coburn <JCoburn@EBSCO.COM>
@zburke
zburke deleted the STCOM-892 branch December 24, 2021 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants