MODWRKFLOW-54: Properly switch to Jackson 3.#151
Merged
Conversation
Use `JsonMapper` directly instead of `ObjectMapper`.
- Use **Jackson 2** as the default behavior.
- Apply common default properties.
- Ensure modules are auto-found just like with **Jackson 2**.
Address some of the problems reported by **SonarQube**.
- Create `AbstractConverterFailure` to address **SonarQube** concerns about directly using `RuntimeException`.
- Unit tests are not written and will likely have to be pending **SonarQube** report from upstream.
- Make `Node` constructor protected as per **SonarQube**.
Apply the newly established way of setting up the `JsonMapper`.
Rename `objectMapper` uses to `mapper`.
- This simplifies the code.
- This removes the now inaccurate `object` reference from the name.
- Not having `json` in the name will allow for this to be changed again in the future (if need be) without as many changes.
rmathew1011
approved these changes
May 28, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Further resolves MODWRKFLOW-54 .
Use
JsonMapperdirectly instead ofObjectMapper.Address some of the problems reported by SonarQube.
AbstractConverterFailureto address SonarQube concerns about directly usingRuntimeException.Nodeconstructor protected as per SonarQube.Apply the newly established way of setting up the
JsonMapper.Rename
objectMapperuses tomapper.objectreference from the name.jsonin the name will allow for this to be changed again in the future (if need be) without as many changes.