MODWRKFLOW-60: Use and support Java 25.#149
Merged
Merged
Conversation
Update minimum Java version to 25. **Lombok** no longer works and it is easier to just completely remove **Lombok** rather than to deal with its problems. - Add all of the getters and setters. - Use the **Apache** logger instead of **Slf4j** because **Spring-Boot** already brings in the **Apache** logger. Rename the `isIterable()` to `getIterable()` for consistency. Add missing `Has*` and other such classes such that the components models all have an annotation enforced getter and setter via interface inheritance. Fix problems with newer Postgresql (17+) where the schema must be specified. - Expose the schema name via `DB_SCHEMA`. - The name includes the tenant name followed by the module name. - The old behavior used a schema name more like `diku_workflow_service` (tenant name plus `workflow_service`). - Ensure that the `public` is still in the schema search path.
The **FOLIO** services are not all ready for **Java** 25. Switch the minimum version to 21. This should still work under both 21 and 25.
The `{}` is not valid for `String.format()`.
Use `%s` instead.
Implement custom function to sanitize input of controller parameters being passed to `String.format()` for logging purposes. Remove unnecessary throwing of `IOException`. Remove unnecessary `String.format()` usage.
|
bv097
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves MODWRKFLOW-60 .
Update minimum Java version to 25.Tested under Java 25, but minimum Java remains at Java 21.
Lombok no longer works and it is easier to just completely remove Lombok rather than to deal with its problems.
Rename the
isIterable()togetIterable()for consistency.Add missing
Has*and other such classes such that the components models all have an annotation enforced getter and setter via interface inheritance.Fix problems with newer Postgresql (17+) where the schema must be specified.
DB_SCHEMA.diku_workflow_service(tenant name plusworkflow_service).publicis still in the schema search path.