Markdown: Some additions and hopefully some bug fixes.#652
Open
not-jakob wants to merge 3 commits intofocus-editor:mainfrom
Open
Markdown: Some additions and hopefully some bug fixes.#652not-jakob wants to merge 3 commits intofocus-editor:mainfrom
not-jakob wants to merge 3 commits intofocus-editor:mainfrom
Conversation
…\. Added alerts. Added [x] with a small x for task higlighting.
not-jakob
changed the title
Collaborator
|
Thanks for your PR. Please don't change the formatting to something that's against this project's conventions. Most of the formatting changes in this PR are unnecessary. Please check the spelling (by allerts did you mean alerts?) Make only the absolutely required changes to implement the features and don't mix them with refactoring (or if it's really needed then make a separate commit with the refactoring so that it's easier to review it). People have sent PR's for highlighters which crash the editor so I must carefully review the code before accepting it. Please make it easier for me as I don't have much time. Thanks |
Author
|
Thanks for the comment. I will change the formatting to so that it fits the project and i will check for typos. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed links not being highlightet correctly.
Added escape character "\".
Added alerts.
Added [x] with a small x for task higlighting.
Some code refactoring.