Skip to content

fix: make sponsor cart discount col wider #988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
santipalenque wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: make sponsor cart discount col wider #988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@
"moment": "^2.29.1",
"moment-duration-format": "^2.3.2",
"moment-timezone": "^0.5.33",
"openstack-uicore-foundation": "5.0.34",
"openstack-uicore-foundation": "5.0.35-beta.0",

@coderabbitai coderabbitai Bot Jun 17, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🌐 Web query:

openstack-uicore-foundation 5.0.35-beta.0 release notes changelog

💡 Result:

There are no public release notes or changelogs specifically for the version 5.0.35-beta.0 of the openstack-uicore-foundation package [1][2]. The openstack-uicore-foundation library, which provides ReactJS/Redux common components for the OpenStack marketing website, does not maintain a centralized or publicly documented changelog or release note file within its primary repository [1][2]. Information regarding package history is generally managed via the npm registry [1][3]. As of June 17, 2026, the available metadata for this package confirms it has undergone numerous version iterations, including various beta releases [4][3][5], but these updates lack explicit changelog documentation [1][2]. Users typically rely on the repository commit history or npm version history to track changes between releases [2][3].

Citations:

🏁 Script executed:

# Check if src/store.js exists and verify the import
if [ -f "src/store.js" ]; then
  echo "=== src/store.js (checking for loggedUserReducer import) ==="
  grep -n "loggedUserReducer\|openstack-uicore-foundation" src/store.js || echo "Import not found or file has different content"
else
  echo "src/store.js not found"
fi

# Check for any other modified files that might contain UI changes
echo ""
echo "=== Checking package.json for scope ==="
wc -l package.json

Repository: fntechgit/summit-admin

Length of output: 317

🏁 Script executed:

# Look for sponsor, cart, or discount-related code/changes in the codebase
echo "=== Searching for sponsor/cart/discount references ==="
rg -i "sponsor.*cart|discount.*column|cart.*discount" --type js --type jsx --type ts --type tsx 2>/dev/null | head -20 || echo "No direct references found"

echo ""
echo "=== Checking file structure to understand scope of changes ==="
git ls-files --modified 2>/dev/null | head -20 || echo "Git info not available; listing key files:"
ls -la src/ 2>/dev/null | head -10

Repository: fntechgit/summit-admin

Length of output: 740

Dependency bump to undocumented beta version without clear justification; possible missing UI changes.

The PR bumps openstack-uicore-foundation from stable 5.0.34 to beta 5.0.35-beta.0, but this version has no publicly available release notes or changelog to document what changes it contains. Additionally, the PR objective mentions addressing a sponsor cart UI layout issue (making the discount column wider), yet no code references to sponsor, cart, or discount UI changes appear in the codebase—raising the question of whether the UI changes are missing from this commit or the PR objective is incorrect.

The import loggedUserReducer from this library is actively used in src/store.js (line 15), so this bump will impact runtime behavior. However, without release notes, there is no way to verify:

  1. That the UI fix mentioned in the PR objective is actually included in this beta version
  2. That the beta version maintains backward compatibility with existing imports and usage
  3. Whether this beta bump is intentional or a mistake

Before merging, please:

  • Confirm the intent of the beta version bump and why stable 5.0.34 is insufficient
  • Check the npm registry or repository commit history for 5.0.35-beta.0 to document what changed
  • Clarify whether the sponsor cart UI changes should be committed separately or are included in the beta version
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@package.json` at line 95, The openstack-uicore-foundation dependency was
bumped to an undocumented beta version 5.0.35-beta.0 from stable 5.0.34, but the
justification and actual changes are unclear. Investigate the npm registry or
the library's repository commit history to document what changes are included in
the beta version 5.0.35-beta.0. Verify that this version includes the sponsor
cart UI layout fixes mentioned in the PR objective, and confirm that the
loggedUserReducer import used in src/store.js remains compatible. Either provide
clear documentation of what changed in the beta version and why it's required
instead of the stable version, or revert to the stable 5.0.34 if the beta bump
was unintended. If the sponsor cart UI changes should be part of this PR, ensure
those code modifications are included in the commit.

"p-limit": "^6.1.0",
"path-browserify": "^1.0.1",
"postcss-loader": "^6.2.1",
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9056,10 +9056,10 @@ open@^10.0.3:
is-inside-container "^1.0.0"
wsl-utils "^0.1.0"

openstack-uicore-foundation@5.0.34:
version "5.0.34"
resolved "https://registry.npmjs.org/openstack-uicore-foundation/-/openstack-uicore-foundation-5.0.34.tgz#28345b0c4338f6a24237862864236d989129c85b"
integrity sha512-gVvfJn7DtKC4s/2HRCOnCqiLFZqWL+P3+Wh0jnNQpGurUrk6UrC2lTkYZ6Vw2W/qqJeJwWjus7rG17+Ff32LaA==
openstack-uicore-foundation@5.0.35-beta.0:
version "5.0.35-beta.0"
resolved "https://registry.yarnpkg.com/openstack-uicore-foundation/-/openstack-uicore-foundation-5.0.35-beta.0.tgz#d3944b07569eafa31706c937280911e1f682e8a7"
integrity sha512-ZNOk5h69GcTvD0V0dZT0pvoAS2/ba/kidYXUI7cEyw8kDWcJ9IF+fES/n70mrrIJ03io0L0q52/7TNJGJ9UGuQ==
dependencies:
use-sync-external-store "^1.6.0"

Expand Down
Loading