Make save-mix respect disabled postconditions#17
Open
zaidenx wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch makes
save-mixrespect the existing command-line flags-disable_rpostand-disable_epostwhen generating mixed-theory SMT-LIB files.Previously,
Verify.Mix.smtlib_specalways included both range and algebraicpostconditions. This patch adds optional
rpostandepostparameters toVerify.Mix.smtlib_specand forwardsverify_rpost/verify_epostfrom the command-line configuration.
Tested:
dune build-disable_rpostwithexamples/openssl/x25519/armv8/x25519_fe64_add.cl-disable_epostwithexamples/openssl/x25519/armv8/x25519_fe64_mul.clObserved behavior:
-disable_rpost, the generatedsave-mixSMT-LIB output changes andthe range postcondition is removed/disabled
-disable_epost, the generated postcondition changes from analgebraic condition like
(assert (not (and true (eqmodP1 ... ))))to
(assert (not (and true true))))