Skip to content

i83 relative path checking cases#84

Merged
reidbaker merged 4 commits intoflutter:mainfrom
reidbaker:i83-relative-path-checking-cases
Apr 16, 2026
Merged

i83 relative path checking cases#84
reidbaker merged 4 commits intoflutter:mainfrom
reidbaker:i83-relative-path-checking-cases

Conversation

@reidbaker
Copy link
Copy Markdown
Contributor

  • Dont trigger on accessabilty labels
  • Handle uris in paths
  • add unit test for anchor fragments

Fixes #83

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances the RelativePathsRule to correctly handle Markdown links that include titles or URL fragments by extracting the path component from the parsed URI. It also adds several test cases to verify these improvements. Feedback was provided to trim the link content before splitting to ensure robust path extraction when leading whitespace is present.

Comment thread tool/dart_skills_lint/lib/src/rules/relative_paths_rule.dart Outdated
@reidbaker reidbaker merged commit 2420128 into flutter:main Apr 16, 2026
7 checks passed
@reidbaker reidbaker deleted the i83-relative-path-checking-cases branch April 16, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

relative paths do not handle accessibility labels or deep links into md files

1 participant