Warn that link checking is for markdown links only#80
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the dart_skills_lint README to include a description of the Path Integrity check under content constraints. The review feedback correctly identifies inaccuracies in the description regarding how absolute paths are handled and the default status of relative path checks, providing a suggestion to clarify that absolute paths are restricted for portability rather than existence.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the documentation for the dart_skills_lint tool by adding Path Constraints to both the README and the formal specification, while also updating the CommonMark Spec version reference. Review feedback highlights an inconsistency where the CommonMark version was updated in the README but not in the specification file. Additionally, suggestions were made to clarify that the current path constraint implementation only supports inline Markdown links, excluding HTML and reference-style links.
|
|
||
| ### 4. Content Constraints | ||
| - **Trailing Whitespace**: Lines in `SKILL.md` should not have trailing whitespace. Exactly 2 spaces at the end of a line are allowed to support Markdown hard line breaks, per the [CommonMark Spec](https://spec.commonmark.org/0.30/#hard-line-breaks). | ||
| - **Trailing Whitespace**: Lines in `SKILL.md` should not have trailing whitespace. Exactly 2 spaces at the end of a line are allowed to support Markdown hard line breaks, per the [CommonMark Spec](https://spec.commonmark.org/0.31.2/#hard-line-breaks). |
There was a problem hiding this comment.
The CommonMark Spec version was updated to 0.31.2 here, but it remains 0.30 in documentation/knowledge/SPECIFICATION.md (line 65). These should be kept in sync to maintain consistency across the documentation.
1 participant
Readme improvement.