Skip to content

Add a skill for linter#74

Merged
johnpryan merged 5 commits intoflutter:mainfrom
reidbaker:r-dart-skills-integration
Apr 14, 2026
Merged

Add a skill for linter#74
johnpryan merged 5 commits intoflutter:mainfrom
reidbaker:r-dart-skills-integration

Conversation

@reidbaker
Copy link
Copy Markdown
Contributor

Author a plain jane skill in the format of https://pub.dev/packages/skills.

I will need some help (and an auth token) to be able to setup this skill using the more complicated contributing documentation for skills in this repo.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@reidbaker reidbaker requested a review from jwren April 10, 2026 18:20
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds documentation for the dart_skills_lint package, including a general README for shipped skills and a specific guide for the dart-skills-lint-validation skill. The feedback identifies a version inconsistency in the setup instructions and recommends adding an assertion to the provided test example to ensure that validation failures are properly reported.

Comment thread tool/dart_skills_lint/skills/dart-skills-lint-validation/SKILL.md
Comment thread tool/dart_skills_lint/skills/dart-skills-lint-validation/SKILL.md Outdated
@jwren jwren requested a review from johnpryan April 13, 2026 20:30
@reidbaker
Copy link
Copy Markdown
Contributor Author

After talking to @jwren out of band the plan is to remove the integration with validate-skill and land the skill as is.
I will file an issue with the bugged validate-skill behavior for different directories.

@johnpryan johnpryan changed the title Add a skill in the location and format of https://pub.dev/packages/skills Add a skill for linter Apr 14, 2026
@johnpryan johnpryan merged commit b06bb02 into flutter:main Apr 14, 2026
7 checks passed
@reidbaker reidbaker deleted the r-dart-skills-integration branch April 15, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants