docs: clarify v11 checkNullOrEmpty default for optional fields #116 - #166
Closed
AzazelSensei wants to merge 1 commit into
Closed
Conversation
A lone maxLength (or email, etc) now fails on blank because checkNullOrEmpty defaults to true. Show the false flag so optional fields stay optional. Default is unchanged.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connection with issue(s)
Connected to #116
Solution description
v11 sets
checkNullOrEmpty: trueon every validator, so a field with onlymaxLength(oremail, etc) fails when left blank. I did not change that default.I added a README example that shows
checkNullOrEmpty: falsefor optional fields, and expanded the v10 → v11 note so this is not just one line in the migration list.Screenshots or Videos
To Do