crypto: fix build with OPENSSL_NO_ENGINE#11771
crypto: fix build with OPENSSL_NO_ENGINE#11771yselkowitz wants to merge 1 commit intofluent:masterfrom
Conversation
ENGINE was deprecated in openssl 3.0 (and disabled in RHEL 10), and completely removed in 4.0. Signed-off-by: Yaakov Selkowitz <yselkowi@redhat.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThree header files conditionally include OpenSSL's ChangesOpenSSL Engine Include Guards
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.Comment |
cosmo0920
left a comment
There was a problem hiding this comment.
It's really good to have. Nice work! 👍
ENGINE was deprecated in openssl 3.0 (and disabled in RHEL 10), and completely removed in 4.0.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.
Summary by CodeRabbit