Skip to content

crypto: fix build with OPENSSL_NO_ENGINE#11771

Open
yselkowitz wants to merge 1 commit intofluent:masterfrom
yselkowitz:openssl4
Open

crypto: fix build with OPENSSL_NO_ENGINE#11771
yselkowitz wants to merge 1 commit intofluent:masterfrom
yselkowitz:openssl4

Conversation

@yselkowitz
Copy link
Copy Markdown

@yselkowitz yselkowitz commented May 3, 2026

ENGINE was deprecated in openssl 3.0 (and disabled in RHEL 10), and completely removed in 4.0.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • [N/A] Example configuration file for the change
  • [N/A] Debug log output from testing the change
  • [N/A] Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • [N/A] Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Summary by CodeRabbit

  • Bug Fixes
    • Fixed compilation failures when OpenSSL is built without engine support enabled.

ENGINE was deprecated in openssl 3.0 (and disabled in RHEL 10), and
completely removed in 4.0.

Signed-off-by: Yaakov Selkowitz <yselkowi@redhat.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e4a9c845-6e4d-4814-89d7-e003bfa9cb65

📥 Commits

Reviewing files that changed from the base of the PR and between 1e69f37 and 0867fe5.

📒 Files selected for processing (3)
  • include/fluent-bit/flb_crypto.h
  • include/fluent-bit/flb_hash.h
  • include/fluent-bit/flb_hmac.h

📝 Walkthrough

Walkthrough

Three header files conditionally include OpenSSL's engine.h only when OPENSSL_NO_ENGINE is not defined, preventing compile errors in OpenSSL builds with engine support disabled.

Changes

OpenSSL Engine Include Guards

Layer / File(s) Summary
Conditional Include Guards
include/fluent-bit/flb_crypto.h, include/fluent-bit/flb_hash.h, include/fluent-bit/flb_hmac.h
OpenSSL engine.h includes wrapped in #ifndef OPENSSL_NO_ENGINE / #endif to prevent compilation failures when OpenSSL disables engine support.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Suggested labels

backport to v4.2.x

Suggested reviewers

  • cosmo0920

Poem

🐰 Three headers stand in morning dew,
Guards now shield what engines do,
OpenSSL's dance, both on and off,
No more compilation scoff!
Hopping forward, clean and bright! 🌿

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'crypto: fix build with OPENSSL_NO_ENGINE' directly and clearly describes the main objective of the changeset—making the build work when OPENSSL_NO_ENGINE is defined.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@cosmo0920 cosmo0920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's really good to have. Nice work! 👍

@cosmo0920 cosmo0920 added this to the Fluent Bit v5.0.5 milestone May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants