fix: make mirror_sync parallel downloads work on Python 3.14 - #386
Open
ahresse wants to merge 1 commit into
Open
fix: make mirror_sync parallel downloads work on Python 3.14#386ahresse wants to merge 1 commit into
ahresse wants to merge 1 commit into
Conversation
The parallel sync path passed a function defined inside sync_urls to multiprocessing.Pool.map. Local functions cannot be pickled, which broke under Python 3.14 where the default start method on Linux changed from fork to forkserver (tasks are pickled to workers). Hoist _sync_one to module level and pass the closure values through a functools.partial, which is picklable. Signed-off-by: Alexandre Esse <alexandre.esse@canonical.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parallel sync path passed a function defined inside sync_urls to multiprocessing.Pool.map. Local functions cannot be pickled, which broke under Python 3.14 where the default start method on Linux changed from fork to forkserver (tasks are pickled to workers).
Hoist _sync_one to module level and pass the closure values through a functools.partial, which is picklable.
Previously undetected because tested on Ubuntu 24.04 (python 3.12).
sources: