Bound BanManager registry lifetime with a TTL#45
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR bounds the per-rule ban audit registry lifetime by applying a TTL to the registry cache entry and pruning expired entries on every save, preventing unbounded growth across ban churn.
Changes:
- Add a BanManager unit test asserting the ban registry cache key expires alongside the bans it tracks.
- Refactor
BanManager::registerBan()to reuseloadRegistry()/saveRegistry()and updatesaveRegistry()to prune expired entries and set a TTL equal to the longest remaining ban lifetime. - Document the behavior change in
CHANGELOG.md.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/Unit/BanManagerTest.php | Adds a TTL-focused test for the ban registry cache entry. |
| src/BanManager.php | Prunes expired registry entries on save and writes the registry with a TTL to prevent unbounded growth. |
| CHANGELOG.md | Notes the registry TTL + pruning behavior under Unreleased. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
a05f796 to
1b0fafc
Compare
The per-rule audit registry was written without a TTL, so it accumulated entries across ban churn until something called listBans() or clearBans() pruned them. Each save now carries a TTL matching the longest-surviving entry and prunes already-expired entries before writing. Concurrent ban() calls for the same rule can still drop one of the registry entries, which is acceptable because the primary ban cache key set by ban() is the source of truth and is unaffected by the race.
1b0fafc to
16cc670
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The per-rule audit registry was written without a TTL, so it accumulated entries across ban churn until something called listBans() or clearBans() pruned them. Each save now carries a TTL matching the longest-surviving entry and prunes already-expired entries before writing. Concurrent ban() calls for the same rule can still drop one of the registry entries, which is acceptable because the primary ban cache key set by ban() is the source of truth and is unaffected by the race.