build.zig: use external translate-c - #11
Conversation
|
Nice, I wasn't aware that translate-c has already been moved out (and that it actually has fixes already). I'm not quite ready to drop 0.15 compatibility yet though, do you have time to fix the PR to decide between the new and old code path via a zig version check like I do here in sokol-zig/build.zig? (otherwise I can do that too but it will delay the merge): |
It, and underlying arocc, are periodically copy/pasted here and used for
Working on it |
|
Done, works for both 0.15.2 and 0.16.0-dev on my Windows machine now. I guess at some point we can either go full external translate-c or go back to bundled one once it's fixed. |
|
Ok thanks! Before merging I'll also give it a whirl on my Mac.
I would probably go "external translateC" (more future-proof I guess?), and we can also drop the 0.15.x backward compatibility code very soon after 0.16 is released - e.g. a few weeks later) |
|
...ok also working fine on Mac with current 0.16-dev and 0.15.2. Merging... |
|
Ok merged. I did one minor 'naming-fix' though :) Thanks for the PR! |
|
...also updated the deps in https://github.com/floooh/sokol-zig-imgui-sample |
fixes missing bindings on Windows (related issue), breaks 0.15.2 compatibility