Skip to content

Test: this pull request should not be managed by the bot #8

Open
rmetzger wants to merge 1 commit into
flinkbot:masterfrom
rmetzger:patch-4
Open

Test: this pull request should not be managed by the bot #8
rmetzger wants to merge 1 commit into
flinkbot:masterfrom
rmetzger:patch-4

Conversation

@rmetzger

@rmetzger rmetzger commented Feb 1, 2019

Copy link
Copy Markdown

No description provided.

@rmetzger

rmetzger commented Feb 1, 2019

Copy link
Copy Markdown
Author

Because the min pr id is 15, this PR is 8.

@rmetzger

rmetzger commented Feb 4, 2019

Copy link
Copy Markdown
Author

Testing collapsable sections:

Bot commands The Flink bot supports the following commands:
  • @flinkbot approve description (similarly, it also supports the `` keywords)
  • @flinkbot approve all

@flinkbot

flinkbot commented Feb 4, 2019

Copy link
Copy Markdown
Owner

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ❌ 1. The [description] looks good.
  • ❌ 2. There is [consensus] that the contribution should go into to Flink.
  • ✅ 3. [Does not need specific [attention] | Needs specific attention for X | Has attention for X by Y]
  • ❌ 4. The [architecture] is sound.
  • ❌ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot approve description to approve the 1st aspect (similarly, it also supports the consensus, architecture and quality keywords)
  • @flinkbot approve all to approve all aspects
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval

@rmetzger

rmetzger commented Feb 4, 2019

Copy link
Copy Markdown
Author
  • ✅1. The [contribution] is well-described.
  • ❌2. There is [consensus] that the contribution should go into to Flink.
  • ❌3. [Does not need specific [attention] | Needs specific attention for X | Has attention for X by Y]
  • ❌4. The [architecture] is sound.
  • ✅ 5. Overall code [quality] is good.

@aljoscha

aljoscha commented Feb 4, 2019

Copy link
Copy Markdown

@flinkbot attention @rmetzger

@rmetzger

rmetzger commented Feb 4, 2019

Copy link
Copy Markdown
Author

the bot in this repo is currently switched off :)

@rmetzger

rmetzger commented Feb 4, 2019

Copy link
Copy Markdown
Author

@flinkbot update comments please :)

@rmetzger

rmetzger commented Feb 4, 2019

Copy link
Copy Markdown
Author

@flinkbot re-render. thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants