Skip to content

Add a NOT_CONTROLABLE example#89

Merged
jorritn merged 4 commits into
flexiblepower:mainfrom
WePositive-energy:nocontrol-example
Jun 29, 2026
Merged

Add a NOT_CONTROLABLE example#89
jorritn merged 4 commits into
flexiblepower:mainfrom
WePositive-energy:nocontrol-example

Conversation

@frandominguezl

Copy link
Copy Markdown
Contributor

Hello! I'm part of WePositive and we needed an example of a non-controllable device for an upcoming partner. We thought it might be useful to include it in the official docs as well.

I have two questions, regarding assets:

  1. I have placed the UML diagram under website/static/img/no-control-sequence-diagram.png, but I feel you handle them in a different way. Could you please indicate how to proceed?
  2. Normally, the examples have a custom top banner. In this case I couldn't find any references on how to create one so, feel free to either accept this without a custom top banner or create one yourselves for this particular example.

Thanks a lot for the review!

Comment thread website/docs/examples/nocontrol.md Outdated
Comment thread website/docs/examples/nocontrol.md Outdated
Comment thread website/docs/examples/nocontrol.md Outdated
"value_upper_limit": -3500.0,
"value_upper_95PPR": -3460.0,
"value_upper_68PPR": -3455.0,
"value_expected": -3450.1,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit strange that the measurement is a positive value and the forecast negative. I suggest to remove the minus signs.

@jorritn

jorritn commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Thanks a lot! Nice contribution.

  1. The way you added the sequence diagrams is exactly how we are doing it too. So, that's fine.
  2. The banner was created by someone else. I don't have the sources either. I'll ask if he can create one for this page too. But it's not a blocker to merge.

@frandominguezl

Copy link
Copy Markdown
Contributor Author

@jorritn Thanks for the review and for the answers! I've just pushed a commit that fixes your comments.

@jorritn jorritn merged commit cd007fe into flexiblepower:main Jun 29, 2026
1 check passed
@frandominguezl frandominguezl deleted the nocontrol-example branch June 29, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants