feat: add envoy ratelimit server protobufs - #39
Merged
Conversation
flemosr
requested changes
Jun 19, 2026
flemosr
left a comment
flemosr
left a comment
Owner
There was a problem hiding this comment.
Hey, thanks for this contribution! I reproduced the generated files with the latest stable protoc, and CI is already passing. We just need two small adjustments before merging.
flemosr
requested changes
Jun 19, 2026
Contributor
Author
Thanks for the quick turnaround! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! Thank you for creating this crate, it fits my use case really well. My project has evolved a little to where I'd prefer to configure envoy's rate limit server (https://github.com/envoyproxy/ratelimit) with this crate rather than json/yaml files, so hopefully this contribution is acceptable!
Changes:
envoyproxy/ratelimitas a submodule undertools/submodules/ratelimitcollect_protos()call inproto-collect.rsto copy the proto filesproto-codegen.rsenvoy-types/src/generated(Some new comments showed up fromgoogle.protobuf.rs, don't think I can take it out oftypes.binso that's why it's left in my PR)