Skip to content

fix(cli): accept required body fields from flags#85

Open
ysyneu wants to merge 1 commit into
feat/ai-srefrom
audit-fix/audit-20260714-body-field-sources
Open

fix(cli): accept required body fields from flags#85
ysyneu wants to merge 1 commit into
feat/ai-srefrom
audit-fix/audit-20260714-body-field-sources

Conversation

@ysyneu

@ysyneu ysyneu commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Summary

  • let generated required request fields come from positional args, typed flags, or --data
  • keep scalar extra-argument rejection and typed-flag override semantics
  • regenerate every affected command from the shared cligen source

Audit evidence

Production sessions exposed version-skew around channel escalate-rule-list: the command help advertised --channel-id, while the target branch positional validator rejected that source before request assembly. The same contradiction affected every generated required body field.

Verification

  • make GOLANGCI_LINT=/tmp/fc-safari-audit-tools/golangci-lint-current (fmt, lint, race tests, build)
  • make check-cards
  • focused scalar and variadic source tests for positional / typed flag / --data
  • cligen regenerated twice with zero diff drift
  • /simplify --uncommitted
  • /review-to-main --uncommitted
  • /review-to-main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant