Skip to content

refactor(http): replace digest auth dependency and enhance logging#311

Merged
moshloop merged 1 commit intomasterfrom
feat/har-capture-and-logger-improvements
Apr 27, 2026
Merged

refactor(http): replace digest auth dependency and enhance logging#311
moshloop merged 1 commit intomasterfrom
feat/har-capture-and-logger-improvements

Conversation

@moshloop
Copy link
Copy Markdown
Member

What

  • Replace external digest auth dependency with internal implementation
  • Add context-aware HTTP logging with access logs and formatters
  • Improve HTTP logging and request tracing consolidation
  • Add verbose logging and JSON-structured output support
  • Implement dynamic log output redirection via SetOutput/GetOutput
  • Extract jsonMD5Raw helper and fix DeterministicUUID UUID generation
  • Make MatchItem case insensitive
  • Fix Windows hx build with .exe suffix

Why

  • Better control over digest auth implementation and reduce external dependencies
  • Enhanced observability with structured logging and trace configuration
  • Support for sensitive data sanitization in logs
  • Fix UUID generation regression where hex-encoded strings were incorrectly parsed
  • Improve build reliability on Windows

Notes

  • Consolidates access log middleware into context logger
  • Adds NO_COLOR environment variable support
  • Includes comprehensive test coverage for hash and logger functionality
  • Updates CI workflow to use gavel for testing and linting

Update go.sum with new dependency versions including cloud.google.com, Azure SDK, and various other packages. Remove unused bindFlags method from logger package as flag binding is now handled elsewhere. Add .gavel/ and .tmp/ to .gitignore for build artifacts.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 27, 2026

Warning

Rate limit exceeded

@moshloop has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 18 minutes and 15 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2d47afb1-818f-4d77-822f-bdc93e020139

📥 Commits

Reviewing files that changed from the base of the PR and between 441e674 and 3c7a57f.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (2)
  • .gitignore
  • logger/default.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/har-capture-and-logger-improvements
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch feat/har-capture-and-logger-improvements

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

Gavel summary

Source Pass Fail Skip Duration
collections 49 0 0 3.2s
files 41 0 0 143ms
github.com/flanksource/commons/certs 4 0 0 480ms
github.com/flanksource/commons/cmd/hx 8 0 0 -
github.com/flanksource/commons/cmd/hx/parse 26 0 0 -
github.com/flanksource/commons/collections/syncmap 10 0 0 -
github.com/flanksource/commons/context 1 0 0 -
github.com/flanksource/commons/duration 2 0 0 -
github.com/flanksource/commons/files 16 0 0 -
github.com/flanksource/commons/har 23 0 0 -
github.com/flanksource/commons/hash 13 0 0 -
github.com/flanksource/commons/http 57 0 2 3.1s
github.com/flanksource/commons/logger 33 0 0 20ms
github.com/flanksource/commons/logger/httpretty/internal/color 15 0 0 -
github.com/flanksource/commons/logger/httpretty/internal/header 1 0 0 -
github.com/flanksource/commons/lookup 7 0 0 30ms
github.com/flanksource/commons/test 5 0 1 70ms
github.com/flanksource/commons/text 1 0 0 -
github.com/flanksource/commons/tokenizer 3 0 0 -
lint: betterleaks 0 0 1 -
lint: eslint 0 0 1 -
lint: golangci-lint 0 0 1 -
lint: jscpd 0 0 1 -
lint: markdownlint 0 0 1 -
lint: pyright 0 0 1 -
lint: ruff 0 0 1 -
lint: vale 0 0 1 -
logger 41 0 0 1ms
set 7 0 0 763.796µs

Totals: 363 passed · 0 failed · 11 skipped · 7.0s

View full results

@moshloop moshloop merged commit 8d82497 into master Apr 27, 2026
7 checks passed
@moshloop moshloop deleted the feat/har-capture-and-logger-improvements branch April 27, 2026 10:18
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 1.51.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant