feat(authz): carry authMobile through SSO registration and invite flows - #1859
Merged
Conversation
The mobile app receives its session as a one-time ticket attached to the allow-listed native redirect (com.openframe.app://auth) — but only when the BFF flow runs with authMobile=true, and on prod dev-ticket-enabled is off. Login sends the flag on /oauth/login; registration and invitation had no way to: the init requests did not accept it, the flow cookies did not carry it, and finalize never forwarded it to /oauth/continue. Wire it end-to-end (init request -> signed flow cookie -> continue query param). Old cookies without the field decode to false — unchanged behavior. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Mobile registration/invitation via browser SSO with
redirectTo=com.openframe.app://authcan redirect back to the app (after #1841), but the app never gets a session: on proddev-ticket-enabled: false, so the one-time ticket is only attached when the BFF flow runs withauthMobile=true— and unlike/oauth/login?authMobile=true, the registration/invite flows had no way to say it.Fix
Wire
authMobileend-to-end, mirroring the login contract:SsoTenantRegistrationInitRequest/SsoInvitationAcceptRequest: new optionalauthMobileparamof_sso_reg/of_sso_invitecookie payloads (Jackson decode of old cookies defaults tofalse)&authMobile=trueto the/oauth/continueredirect;continueFlowalready accepts it and gates onmobile-auth-enabledFrontend follow-up: the app-shell registration/invite calls must send
authMobile=truealongsideredirectTo=com.openframe.app://auth(same asloginUrldoes).Cross-compiled against openframe-saas-shared auth-server (999-SNAPSHOT).
🤖 Generated with Claude Code