[MeshCentral - 1]. Remote desktop: manageable shortcuts with settings modal - #247
Open
romanivan-flamingo wants to merge 1 commit into
Open
[MeshCentral - 1]. Remote desktop: manageable shortcuts with settings modal#247romanivan-flamingo wants to merge 1 commit into
romanivan-flamingo wants to merge 1 commit into
Conversation
Replace the hardcoded Apply Shortcut list with a user-managed one: - Shortcuts Settings modal (drag-reorder, delete, add with modifier checkboxes + key input), draft state applied on Save - shortcuts persisted in localStorage as comboToSequence-compatible combo strings; defaults match the previous hardcoded set - Apply Shortcut submenu generated from the stored list with a leading Manage Shortcuts item - single sendShortcut(combo) path replaces the VK-array remapping and the separate Ctrl+Alt+Del handler, guarded on an active connection Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of the Remote Access Approval Flow epic (ClickUp 86agfp8w9), subtask [Admin FE] Shortcuts manager (86ajx048c). Figma: Shortcuts Settings modal (1-70785), actions menu (1-70731).
localStorageascomboToSequence-compatible combo strings ('shift+win+m') - the exact formatMeshDesktop.sendKeyComboconsumes. Defaults = the previous hardcoded 8.sendShortcut(combo)path (drops the VK-array remapping table and the separate Ctrl+Alt+Del handler; 'alt+ctrl+del' keeps its secure-attention special case insideMeshDesktop), now guarded on an active connection.Test plan
remote-desktop:shortcuts)🤖 Generated with Claude Code