Skip to content

[MeshCentral - 1]. Remote desktop: manageable shortcuts with settings modal - #247

Open
romanivan-flamingo wants to merge 1 commit into
mainfrom
hotfix/remote-shortcuts-manager
Open

[MeshCentral - 1]. Remote desktop: manageable shortcuts with settings modal#247
romanivan-flamingo wants to merge 1 commit into
mainfrom
hotfix/remote-shortcuts-manager

Conversation

@romanivan-flamingo

Copy link
Copy Markdown
Contributor

Summary

Part of the Remote Access Approval Flow epic (ClickUp 86agfp8w9), subtask [Admin FE] Shortcuts manager (86ajx048c). Figma: Shortcuts Settings modal (1-70785), actions menu (1-70731).

  • New Shortcuts Settings modal: reorder via drag (dnd-kit, same pattern as scripts v2 schedule), delete, add new shortcut (Shift/Alt/Ctrl/Win checkboxes + key input). Edits live in a draft and apply on Save Shortcuts only.
  • Shortcuts are stored in localStorage as comboToSequence-compatible combo strings ('shift+win+m') - the exact format MeshDesktop.sendKeyCombo consumes. Defaults = the previous hardcoded 8.
  • Apply Shortcut submenu is generated from the stored list, with a leading Manage Shortcuts item per design.
  • Sending unified into one sendShortcut(combo) path (drops the VK-array remapping table and the separate Ctrl+Alt+Del handler; 'alt+ctrl+del' keeps its secure-attention special case inside MeshDesktop), now guarded on an active connection.

Test plan

  • Apply Shortcut submenu shows Manage Shortcuts + the 8 defaults
  • Modal: drag-reorder (pointer + keyboard), delete, add (valid key, invalid key -> toast, duplicate -> toast)
  • Close without Save discards edits; Save persists across reload (remote-desktop:shortcuts)
  • On a live Windows device: Win+M / Win+L / Alt+Ctrl+Del and a newly added custom combo reach the agent; toasts show combo label + description
  • Regression: power actions, Enable Input, Clipboard Sharing still work from the same menu

🤖 Generated with Claude Code

Replace the hardcoded Apply Shortcut list with a user-managed one:
- Shortcuts Settings modal (drag-reorder, delete, add with modifier
  checkboxes + key input), draft state applied on Save
- shortcuts persisted in localStorage as comboToSequence-compatible
  combo strings; defaults match the previous hardcoded set
- Apply Shortcut submenu generated from the stored list with a leading
  Manage Shortcuts item
- single sendShortcut(combo) path replaces the VK-array remapping and
  the separate Ctrl+Alt+Del handler, guarded on an active connection

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@romanivan-flamingo
romanivan-flamingo requested a review from a team as a code owner August 18, 2026 14:32
@romanivan-flamingo
romanivan-flamingo requested a review from a team August 18, 2026 14:32
@romanivan-flamingo romanivan-flamingo self-assigned this Aug 18, 2026
@romanivan-flamingo romanivan-flamingo changed the title Remote desktop: manageable shortcuts with settings modal MeshCentral - 1. Remote desktop: manageable shortcuts with settings modal Aug 18, 2026
@romanivan-flamingo romanivan-flamingo changed the title MeshCentral - 1. Remote desktop: manageable shortcuts with settings modal [MeshCentral - 1] Remote desktop: manageable shortcuts with settings modal Aug 18, 2026
@romanivan-flamingo romanivan-flamingo changed the title [MeshCentral - 1] Remote desktop: manageable shortcuts with settings modal [MeshCentral - 1]. Remote desktop: manageable shortcuts with settings modal Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant