fix(NATSRS-003): Info::cluster field uses skip_serializing_if but is Option<ClusterInfo>, missing Option::is_none guard

[flamingo]

Closes findings from rule NATSRS-003 — Info::cluster field uses skip_serializing_if but is Option, missing Option::is_none guard.

Draft — this is a starting point, not a finished change. The fix required judgment, so read it before trusting it.

#	Fix confidence	Finding	Location
1	🟢 95 high	Info::cluster field uses skip_serializing_if but is Option, missing Option::is_none guard	async-nats/src/jetstream/consumer/mod.rs:183
2	🟢 92 high	Info::pause_remaining is Option but uses serde_nanos instead of serde_nanos::option	async-nats/src/jetstream/consumer/mod.rs:192
3	🟢 92 high	Info::pause_remaining Option field missing skip_serializing_if = "Option::is_none"	async-nats/src/jetstream/consumer/mod.rs:192
4	🟡 72 medium	pause_remaining field gated on server_2_11 but pause_remaining is a Duration that can be zero when consumer is not paused — missing paused=false guard in deserialization	async-nats/src/jetstream/consumer/mod.rs:188
5	🟢 90 high	Copyright year range ends at 2023 — may need updating for files modified in 2024/2025	async-nats/src/jetstream/consumer/mod.rs:1

What changed — and what was deliberately left — is explained per finding as inline review comments on the lines each finding touched.

---

Run: https://product-hub.flamingo.so/admin/code-review
Run id: c70be0ee-08a4-4bde-9f5c-d994d0e1d4f2

Merging this PR is recorded as acceptance of the rule that produced it;
closing it unmerged is recorded as rejection. Both feed rule health, so
closing a wrong suggestion is useful rather than merely tidy.

[flamingo]

🦩 What this fix changed, finding by finding

5 finding(s) fixed in this draft — 5 explained inline on the diff.

[flamingo]

🦩 🟠 Info::cluster field uses skip_serializing_if but is Option, missing Option::is_none guard

Changed #[serde(skip_serializing_if = "is_default")] to #[serde(default, skip_serializing_if = "Option::is_none")] on the cluster field of Info (line 183). Added default attribute and replaced is_default with Option::is_none to correctly handle Option<ClusterInfo> serialization.

🤖 Prompt for AI agents

In async-nats/src/jetstream/consumer/mod.rs around line 183, review and complete this code-review fix: Info::cluster field uses skip_serializing_if but is Option<ClusterInfo>, missing Option::is_none guard.
What the draft fix changed: Changed `#[serde(skip_serializing_if = "is_default")]` to `#[serde(default, skip_serializing_if = "Option::is_none")]` on the `cluster` field of `Info` (line 183). Added `default` attribute and replaced `is_default` with `Option::is_none` to correctly handle `Option<ClusterInfo>` serialization.
Verify the change is correct and complete; do not refactor unrelated code.

fix confidence: 🟢 95 high — react 👍/👎 to teach the reviewer

[flamingo]

🦩 🔴 Info::pause_remaining is Option but uses serde_nanos instead of serde_nanos::option

Changed #[serde(default, with = "serde_nanos")] to #[serde(default, with = "serde_nanos::option", skip_serializing_if = "Option::is_none")] on the pause_remaining field of Info (line 192). This fixes both the wrong adapter (serde_nanos → serde_nanos::option for Option) and adds the missing skip_serializing_if guard. Note: this assumes serde_nanos::option is available in the version of serde_nanos used by this crate — if the crate uses an older version that lacks this module, a compile error will result and an alternative approach (custom serialize/deserialize functions) would be needed.

🤖 Prompt for AI agents

In async-nats/src/jetstream/consumer/mod.rs around line 192, review and complete this code-review fix: Info::pause_remaining is Option<Duration> but uses `serde_nanos` instead of `serde_nanos::option`.
What the draft fix changed: Changed `#[serde(default, with = "serde_nanos")]` to `#[serde(default, with = "serde_nanos::option", skip_serializing_if = "Option::is_none")]` on the `pause_remaining` field of `Info` (line 192). This fixes both the wrong adapter (serde_nanos → serde_nanos::option for Option<Duration>) and adds the missing skip_serializing_if guard. Note: this assumes `serde_nanos::option` is available in the version of `serde_nanos` used by this crate — if the crate uses an older version that lacks this module, a compile error will result and an alternative approach (custom serialize/deserialize functions) would be needed.
Verify the change is correct and complete; do not refactor unrelated code.

fix confidence: 🟢 92 high — react 👍/👎 to teach the reviewer

[flamingo]

🦩 🟠 Info::pause_remaining Option field missing skip_serializing_if = "Option::is_none"

Same change as finding 2 — the skip_serializing_if = "Option::is_none" was added as part of the combined fix to pause_remaining in finding 2. Both findings 2 and 3 are resolved by the single attribute change on line 192.

🤖 Prompt for AI agents

In async-nats/src/jetstream/consumer/mod.rs around line 192, review and complete this code-review fix: Info::pause_remaining Option<Duration> field missing skip_serializing_if = "Option::is_none".
What the draft fix changed: Same change as finding 2 — the `skip_serializing_if = "Option::is_none"` was added as part of the combined fix to `pause_remaining` in finding 2. Both findings 2 and 3 are resolved by the single attribute change on line 192.
Verify the change is correct and complete; do not refactor unrelated code.

fix confidence: 🟢 92 high — react 👍/👎 to teach the reviewer

[flamingo]

🦩 🔴 pause_remaining field gated on server_2_11 but pause_remaining is a Duration that can be zero when consumer is not paused — missing paused=false guard in deserialization

Added a doc comment to pause_remaining warning that paused is the authoritative gate and that both None and Some(Duration::ZERO) may indicate the consumer is not paused. This is a documentation-only change in this file; it does not fix the underlying semantic issue that callers outside this file may misinterpret Some(Duration::ZERO). A complete fix would also require updating call sites and potentially adding a helper method, but those are in other files not visible here.

🤖 Prompt for AI agents

In async-nats/src/jetstream/consumer/mod.rs around line 188, review and complete this code-review fix: pause_remaining field gated on server_2_11 but pause_remaining is a Duration that can be zero when consumer is not paused — missing paused=false guard in deserialization.
What the draft fix changed: Added a doc comment to `pause_remaining` warning that `paused` is the authoritative gate and that both `None` and `Some(Duration::ZERO)` may indicate the consumer is not paused. This is a documentation-only change in this file; it does not fix the underlying semantic issue that callers outside this file may misinterpret `Some(Duration::ZERO)`. A complete fix would also require updating call sites and potentially adding a helper method, but those are in other files not visible here.
Verify the change is correct and complete; do not refactor unrelated code.

fix confidence: 🟡 72 medium — react 👍/👎 to teach the reviewer

[flamingo]

🦩 🟠 Copyright year range ends at 2023 — may need updating for files modified in 2024/2025

Changed // Copyright 2020-2023 The NATS Authors to // Copyright 2020-2025 The NATS Authors on line 1. This is a mechanical year-range update. The only risk is if the project has a policy of using a different end year (e.g., the actual last modification year rather than the current year), but 2025 is consistent with the finding's suggestion.

🤖 Prompt for AI agents

In async-nats/src/jetstream/consumer/mod.rs around line 1, review and complete this code-review fix: Copyright year range ends at 2023 — may need updating for files modified in 2024/2025.
What the draft fix changed: Changed `// Copyright 2020-2023 The NATS Authors` to `// Copyright 2020-2025 The NATS Authors` on line 1. This is a mechanical year-range update. The only risk is if the project has a policy of using a different end year (e.g., the actual last modification year rather than the current year), but 2025 is consistent with the finding's suggestion.
Verify the change is correct and complete; do not refactor unrelated code.

fix confidence: 🟢 90 high — react 👍/👎 to teach the reviewer