Skip to content

Ship CoreModule.js in both release archives - #79

Closed
mikhailm-coder wants to merge 1 commit into
masterfrom
hotfix/mesh-coremodule-release-asset
Closed

Ship CoreModule.js in both release archives#79
mikhailm-coder wants to merge 1 commit into
masterfrom
hotfix/mesh-coremodule-release-asset

Conversation

@mikhailm-coder

@mikhailm-coder mikhailm-coder commented Aug 10, 2026

Copy link
Copy Markdown

Why

Deployed OpenFrame machines currently receive the mesh agent's JS core from a frozen snapshot baked into the openframe-client JAR (ToolAgentFileController, marked TODO: remove after github artifact is implemented). Edits to CoreModule.js in this repo never reach machines. This PR is step 1 of retiring that stopgap: make the release archives carry CoreModule.js so the openframe-client can install/update it as a versioned GITHUB asset (oss-lib config flip lands separately).

What

release.ymlPrepare release artifacts:

  • Windows zip: add CoreModule.js at the archive root next to meshagent.exe.
  • macOS tar.gz: add CoreModule.js as a sibling of MeshAgent.app — deliberately outside the bundle so the codesign/notarization seal stays intact; this is also exactly where the agent looks for it in OpenFrame mode (agentcore.c builds the path "next to .app").
  • Preflight check that CoreModule.js exists in the checkout; release-notes line listing the new archive content.
  • Hardened the zip line to use "${BINARY_NAME}.exe" (shell env) instead of raw ${{ env.BINARY_NAME }} interpolation.

Windows Authenticode signing is unaffected — it signs the bare .exe one job earlier.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features
    • Release packages now include the OpenFrame agent core.
    • Both macOS and Windows client archives contain the required core module.

Windows zip gets it at root next to meshagent.exe; macOS tar.gz gets it
as a sibling of MeshAgent.app (where the agent loads it from in
OpenFrame mode) to keep the codesign/notarization seal intact.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 2cb7caba-6dd2-42f6-a1ef-34d0458516b8

📥 Commits

Reviewing files that changed from the base of the PR and between 9918480 and 90de679.

📒 Files selected for processing (1)
  • .github/workflows/release.yml

📝 Walkthrough

Walkthrough

The release workflow now validates, stages, and packages CoreModule.js with both macOS and Windows client archives. The release notes identify the file as part of both archives.

Changes

Release packaging

Layer / File(s) Summary
Stage and document CoreModule.js
.github/workflows/release.yml
The workflow checks for CoreModule.js, stages it for macOS and Windows, adds it to both archives, and updates the release notes.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding CoreModule.js to both release archives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch hotfix/mesh-coremodule-release-asset

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants