Ship CoreModule.js in both release archives - #79
Closed
mikhailm-coder wants to merge 1 commit into
Closed
Conversation
Windows zip gets it at root next to meshagent.exe; macOS tar.gz gets it as a sibling of MeshAgent.app (where the agent loads it from in OpenFrame mode) to keep the codesign/notarization seal intact. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe release workflow now validates, stages, and packages ChangesRelease packaging
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
danylo-babenko-flamingo
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Deployed OpenFrame machines currently receive the mesh agent's JS core from a frozen snapshot baked into the openframe-client JAR (
ToolAgentFileController, markedTODO: remove after github artifact is implemented). Edits toCoreModule.jsin this repo never reach machines. This PR is step 1 of retiring that stopgap: make the release archives carryCoreModule.jsso the openframe-client can install/update it as a versioned GITHUB asset (oss-lib config flip lands separately).What
release.yml→Prepare release artifacts:CoreModule.jsat the archive root next tomeshagent.exe.CoreModule.jsas a sibling ofMeshAgent.app— deliberately outside the bundle so the codesign/notarization seal stays intact; this is also exactly where the agent looks for it in OpenFrame mode (agentcore.cbuilds the path "next to .app").CoreModule.jsexists in the checkout; release-notes line listing the new archive content."${BINARY_NAME}.exe"(shell env) instead of raw${{ env.BINARY_NAME }}interpolation.Windows Authenticode signing is unaffected — it signs the bare
.exeone job earlier.🤖 Generated with Claude Code
Summary by CodeRabbit