Skip to content

fix(MAJORLEA-006): Logo.tsx imports MUI SvgIcon instead of using @flamingo/ui-kit for brand/product icons #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
flamingo wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −5
Draft

fix(MAJORLEA-006): Logo.tsx imports MUI SvgIcon instead of using @flamingo/ui-kit for brand/product icons #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions frontend/src/components/Logo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
import React from 'react';

@flamingo flamingo Bot Aug 14, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦩 🟠 Logo.tsx imports MUI SvgIcon instead of using @flamingo/ui-kit for brand/product icons

Replaced the SvgIcon/local SVG approach with MlgLogo from @flamingo/ui-kit/components/icons as directed by MAJORLEA-006. Removed imports of SvgIcon, SvgIconProps from @mui/material and LogoSvg from ../assets/logo.svg. The Logo wrapper now forwards its ref and props to MlgLogo. Risks: (a) the exact sub-path @flamingo/ui-kit/components/icons is assumed from the suggested fix — the actual package export path may differ (e.g. @flamingo/ui-kit or @flamingo/ui-kit/icons); (b) MlgLogo may not accept a forwarded SVGSVGElement ref, so the ref type is inferred via React.ComponentProps<typeof MlgLogo> rather than hard-coded — if MlgLogo does not support ref forwarding at all this will need adjustment; (c) @flamingo/ui-kit must be listed as a dependency in package.json (not visible here). A reviewer should verify the correct import path and ref compatibility before merging.

🤖 Prompt for AI agents 
In frontend/src/components/Logo.tsx around line 1, review and complete this code-review fix: Logo.tsx imports MUI SvgIcon instead of using @flamingo/ui-kit for brand/product icons.
What the draft fix changed: Replaced the `SvgIcon`/local SVG approach with `MlgLogo` from `@flamingo/ui-kit/components/icons` as directed by MAJORLEA-006. Removed imports of `SvgIcon`, `SvgIconProps` from `@mui/material` and `LogoSvg` from `../assets/logo.svg`. The `Logo` wrapper now forwards its ref and props to `MlgLogo`. Risks: (a) the exact sub-path `@flamingo/ui-kit/components/icons` is assumed from the suggested fix — the actual package export path may differ (e.g. `@flamingo/ui-kit` or `@flamingo/ui-kit/icons`); (b) `MlgLogo` may not accept a forwarded `SVGSVGElement` ref, so the ref type is inferred via `React.ComponentProps<typeof MlgLogo>` rather than hard-coded — if `MlgLogo` does not support `ref` forwarding at all this will need adjustment; (c) `@flamingo/ui-kit` must be listed as a dependency in `package.json` (not visible here). A reviewer should verify the correct import path and ref compatibility before merging.
The fix is LOW CONFIDENCE — verify it is correct and finish whatever it left incomplete.

fix confidence: 🔴 52 low — review closely — react 👍/👎 to teach the reviewer

import { SvgIcon, SvgIconProps } from '@mui/material';
import LogoSvg from '../assets/logo.svg';
import { MlgLogo } from '@flamingo/ui-kit/components/icons';

export const Logo = React.forwardRef<SVGSVGElement, SvgIconProps>((props, ref) => {
export const Logo = React.forwardRef<SVGSVGElement, React.ComponentProps<typeof MlgLogo>>((props, ref) => {
return (
<SvgIcon ref={ref} component={LogoSvg} inheritViewBox {...props} />
<MlgLogo ref={ref} {...props} />
);
});
});