Skip to content
This repository was archived by the owner on Jun 8, 2026. It is now read-only.

Retire schema guard from package workspace contract (#148)#153

Merged
fitz123 merged 15 commits into
mainfrom
issue-148-control-agent-contract-cleanup
Jun 7, 2026
Merged

Retire schema guard from package workspace contract (#148)#153
fitz123 merged 15 commits into
mainfrom
issue-148-control-agent-contract-cleanup

Conversation

@fitz123

@fitz123 fitz123 commented Jun 6, 2026

Copy link
Copy Markdown
Owner

Summary

Stacked on #151 / issue-148-package-cli-workspace-contract.

This follow-up completes the corrected #148 architecture:

  • treats --workspace as the control/app workspace;
  • allows absolute agents.*.workspaceCwd outside the control workspace;
  • retires schema/write-guard package contract (schema.md, MINIME_SCHEMA_PATH, Pi guard extension, Claude guard hooks);
  • keeps Telegram/Discord/Tavily as control-workspace/global secrets;
  • passes non-secret control path refs to Pi parent/cron/subagent children;
  • keeps Tavily on dedicated control-root config/secrets.sops.yaml + tavily.api_key;
  • adds deterministic schema/guard contract removal check and private cleanup artifact.

Validation

Ralphex reported:

  • git diff --check
  • npm run typecheck
  • npm run check:schema-guard-contract
  • npm run validate-config
  • npm test — 1434 pass, 0 fail
  • npm run build
  • npm run workspace:validate -- --workspace ./test-fixtures/minimal-workspace
  • npm pack --dry-run

After syncing the final #151 base commit into this branch, I re-ran:

  • git diff --check
  • cd bot && npm run check:schema-guard-contract
  • cd bot && npm run typecheck
  • cd bot && npm run validate-config
  • cd bot && npm test — 1434 pass, 0 fail
  • cd bot && npm run build
  • cd bot && npm run workspace:validate -- --workspace ./test-fixtures/minimal-workspace
  • cd bot && npm pack --dry-run

Notes

@fitz123

fitz123 commented Jun 6, 2026

Copy link
Copy Markdown
Owner Author

@copilot please re-review — fixes pushed since the last review

@fitz123

fitz123 commented Jun 6, 2026

Copy link
Copy Markdown
Owner Author

@copilot please re-review — fixes pushed since the last review

@fitz123

fitz123 commented Jun 6, 2026

Copy link
Copy Markdown
Owner Author

@copilot please review this pull request for correctness and security.

Copilot AI commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

@copilot please re-review — fixes pushed since the last review

Addressed one follow-up issue in 4049c3e: Pi child env propagation now passes explicit control config/crons overrides as resolved absolute paths, with parent and subagent tests updated and revalidated.

Copilot AI commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

@copilot please review this pull request for correctness and security.

Reviewed the stacked diff for correctness and security and didn’t find any blocking issues. I also re-ran the relevant bot validations locally after installing dependencies: npm run typecheck, node --experimental-test-module-mocks --import tsx --test src/__tests__/pi-rpc-protocol.test.ts, npm run check:schema-guard-contract, npm run validate-config, and npm run workspace:validate -- --workspace ./test-fixtures/minimal-workspace all passed.

@fitz123

fitz123 commented Jun 6, 2026

Copy link
Copy Markdown
Owner Author

@copilot please re-review — fixes pushed since the last review

@fitz123 fitz123 force-pushed the issue-148-control-agent-contract-cleanup branch from d694e97 to 4049c3e Compare June 6, 2026 20:25
Copilot stopped work on behalf of fitz123 due to an error June 6, 2026 20:27
@fitz123 fitz123 force-pushed the issue-148-control-agent-contract-cleanup branch from 4049c3e to be3f263 Compare June 7, 2026 08:16
@fitz123 fitz123 changed the base branch from issue-148-package-cli-workspace-contract to main June 7, 2026 08:16
@fitz123

fitz123 commented Jun 7, 2026

Copy link
Copy Markdown
Owner Author

@copilot please re-review — fixes pushed since the last review

Copilot AI commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

@copilot please re-review — fixes pushed since the last review

Re-reviewed the latest follow-up around be3f263. The updated assertions now match the implementation in buildPiSpawnEnv() / buildPiSubagentChildSpawnEnv(), which resolves explicit MINIME_CONFIG_PATH and MINIME_CRONS_PATH overrides to absolute control-workspace paths before passing them to Pi children. Revalidated with cd bot && npm run typecheck, cd bot && node --experimental-test-module-mocks --import tsx --test src/__tests__/pi-rpc-protocol.test.ts, and cd bot && npm run check:schema-guard-contract; I didn’t find any new blocking correctness or security issues in the latest fix.

@fitz123 fitz123 merged commit 2ab38d2 into main Jun 7, 2026
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants