Retire schema guard from package workspace contract (#148)#153
Conversation
|
@copilot please re-review — fixes pushed since the last review |
|
@copilot please re-review — fixes pushed since the last review |
|
@copilot please review this pull request for correctness and security. |
Addressed one follow-up issue in |
Reviewed the stacked diff for correctness and security and didn’t find any blocking issues. I also re-ran the relevant bot validations locally after installing dependencies: |
|
@copilot please re-review — fixes pushed since the last review |
d694e97 to
4049c3e
Compare
4049c3e to
be3f263
Compare
|
@copilot please re-review — fixes pushed since the last review |
Re-reviewed the latest follow-up around |
Summary
Stacked on #151 /
issue-148-package-cli-workspace-contract.This follow-up completes the corrected #148 architecture:
--workspaceas the control/app workspace;agents.*.workspaceCwdoutside the control workspace;schema.md,MINIME_SCHEMA_PATH, Pi guard extension, Claude guard hooks);config/secrets.sops.yaml+tavily.api_key;Validation
Ralphex reported:
git diff --checknpm run typechecknpm run check:schema-guard-contractnpm run validate-confignpm test— 1434 pass, 0 failnpm run buildnpm run workspace:validate -- --workspace ./test-fixtures/minimal-workspacenpm pack --dry-runAfter syncing the final #151 base commit into this branch, I re-ran:
git diff --checkcd bot && npm run check:schema-guard-contractcd bot && npm run typecheckcd bot && npm run validate-configcd bot && npm test— 1434 pass, 0 failcd bot && npm run buildcd bot && npm run workspace:validate -- --workspace ./test-fixtures/minimal-workspacecd bot && npm pack --dry-runNotes