Add "types" to the package's "exports"#2
Open
divergentdave wants to merge 1 commit into
Open
Conversation
|
@fission-codes Can this be merged soon? Am also experiencing this using |
gobengo
added a commit
to storacha/one-webcrypto
that referenced
this pull request
Oct 24, 2023
same motivation fission-codes#2 Signed-off-by: Benjamin Goering <171782+gobengo@users.noreply.github.com>
|
We forked it here https://github.com/storacha/one-webcrypto |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When importing this package using a newer version of TypeScript, with the settings
"module": "nodenext", "moduleResolution": "nodenext", TypeScript was not able to find the declarations file, because it was only checking the exports.This PR adds the declaration file to the package's exports, while keeping the "types" key for both older versions of TypeScript, and for the TS badge on NPM.
(FWIW, I was also able to work around this by adding the following to
tsconfig.json, but this may be fragile:"paths": {"one-webcrypto": "./node_modules/one-webcrypto/index.d.ts"})