Send all batchable commands in sdp offer#544
Open
roznawsk wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the WebRTC client’s command queue/renegotiation flow so multiple locally queued addTrack operations can be included in a single SDP offer/answer cycle (i.e., batchable commands are drained right before creating the offer).
Changes:
- Mark
addTrackcommands as batchable and drain batchable commands inonOfferDatabefore creating/sending the SDP offer. - Avoid sending redundant
renegotiateTrackswhen anaddTrackhappens while a renegotiation is already pending. - Add vitest coverage for batching behavior and extend test fixtures/mocks to support the new flow.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/webrtc-client/src/CommandsQueue.ts | Adds batching support and multi-notifier tracking for queued commands. |
| packages/webrtc-client/src/webRTCEndpoint.ts | Drains batchable commands before generating an SDP offer. |
| packages/webrtc-client/src/tracks/LocalTrackManager.ts | Skips redundant renegotiateTracks while renegotiation is already pending. |
| packages/webrtc-client/tests/methods/addTrackBatching.test.ts | New tests covering batching and error isolation within a batched cycle. |
| packages/webrtc-client/tests/fixtures.ts | Adds helper to build multi-track SDP answers for tests. |
| packages/webrtc-client/tests/mocks.ts | Adjusts RTCPeerConnection mock signaling state for instability checks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This allows for negotiating both audio and video at the same time.
Motivation and Context
Why is this change required? What problem does it solve? If it fixes an open
issue, please link to the issue here.
Documentation impact
Types of changes
not work as expected)