Add concurrency control + self-CI validation to shared workflows - #19
Open
ClaudiaFang wants to merge 5 commits into
Open
Add concurrency control + self-CI validation to shared workflows#19ClaudiaFang wants to merge 5 commits into
ClaudiaFang wants to merge 5 commits into
Conversation
…CI validation Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011zVvyzHgtk7C51dpi8CGrp
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
concurrency:block to.github/workflows/obsidian-plugin-ci.yml(the shared,workflow_call-triggered Obsidian plugin CI template). Previously this reusable workflow had zero dedup for its consumers, meaning rapid pushes to the same branch would queue/run independently, and in principle two near-simultaneous pushes to main could both clear therelease-metadatajob'sneeds: [filter, lint, test]gate close together and racenpx semantic-release. The group is keyed bygithub.repository(since multiple repos share this template) and branch, scoped separately per event type (push vs PR), matching the convention already used in_pg-migration-deploy.yml..github/workflows/self-ci.yml— this repo previously had no self-CI at all validating its own reusable workflow files. The new workflow runsactionlintviareviewdog/action-actionlint@v1on push/PR to.github/workflows/**, to catch YAML/syntax/expression errors before they reach consumer repos. It has its own concurrency group (keyed byself-ci-...) so it doesn't collide with Change 1's group.This is part of a cross-repo CI architecture review across firstsun-dev repos.
Test plan
python3 -c "import yaml,sys; yaml.safe_load(open(sys.argv[1]))"confirms bothobsidian-plugin-ci.ymlandself-ci.ymlare syntactically valid YAML.self-ci.yml's actionlint job will run automatically on this PR (paths touch.github/workflows/**) and should pass.🤖 Generated with Claude Code
https://claude.ai/code/session_011zVvyzHgtk7C51dpi8CGrp