markdown: extend h2 heading underline across full title - #44
Merged
Conversation
Goldmark splits multi-word headings at the last space into two Text nodes, and lipgloss emits the parameterless reset "\x1b[m" between the styled segments. The post-processing that re-asserts the underline SGR after every reset only matched "\x1b[0m", so the middle reset cleared the underline and the trailing word rendered without it — visible as a short underline that stops part-way through the heading. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Multi-word level-2 headings rendered with a short underline that stopped part-way through the title (e.g.
The data modelhad onlyThe dataunderlined). Root cause:Textnodes ("The data"+" model").\x1b[m(shorthand for\x1b[0m) between styled segments.renderHeadingthat re-asserts\x1b[4mafter every reset only matched the explicit\x1b[0mform, so the middle reset cleared the underline and the trailing word rendered without it.Fix is one extra
strings.ReplaceAllfor\x1b[m, plus a regression test that asserts the underline-off SGR sits after the last visible character of the heading (covers both ATX## ...and setext---underline forms).Test plan
go test ./markdown/...(full package suite passes)TestMarkdownH2UnderlineSpansFullHeadingfails onmainand passes with the fixgo test ./...(full repo)🤖 Generated with Claude Code