Optimization: Share your things and play nice - #127
Open
dirwin31 wants to merge 1 commit into
Open
Conversation
dirwin31
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Build navigation instruction data once per valid loop and share it between the navInstruction
and NavInstructionState publishers. Previously, each publisher independently built the same
payload.
Preserves publication cadence, route updates, invalid-message handling, and stale-state
cleanup.
Verification:
All six navigation tests passed.
Twelve supplemental before/after comparisons confirmed identical messages and state updates
across valid navigation, invalid location, missing route/progress, route replacement, and
route clearing, using both Vienna and MUTCD signs.
Confirmed shared payloads remain unchanged and valid loops perform one build instead of two.