Honda Accord 11G: integrate native DOM control stack (NATIVE-01–14) - #111
Honda Accord 11G: integrate native DOM control stack (NATIVE-01–14)#111J3DOK3DO wants to merge 13 commits into
Conversation
Native-14 road-validation updateThe PR description has been updated with the completed NATIVE-13/14 road validation and the focused qlog analysis. Key result:
Evidence identities:
The connector incident is documented as non-blocking. Host verification and road validation are complete; the patch series is ready for maintainer review. |
3bda5ad to
a7ea595
Compare
Current-DOM conflict resolution completedPR #111 has been replayed onto the live
Verification on the isolated current-DOM replay:
The two qualified failures are unrelated live-DOM inconsistencies and are not in symbols modified by this PR: the generic force-stop helper/test expectation mismatch, and a Genesis G70 helper/test expectation mismatch. The PR remains a draft pending a device boot/smoke check and proportionate road confirmation of the rebased head. |
Description
This PR integrates the complete Honda Accord 11G control stack into StarPilot DOM's native architecture.
The implementation preserves DOM ownership of planning, MPC, longcontrol, radar, lateral control, model processing, delay estimation, Honda CAN handling, and parameter learning. Accord-specific behavior is applied through explicit
HONDA_ACCORD_11Gpolicy gates so generic DOM behavior and other Honda platforms retain their existing paths.The current-DOM replay contains NATIVE-01 through NATIVE-14 as 13 commits (
NATIVE-09/10remains intentionally combined). The earlier LKG-only AGNOS 19.6.13 compatibility commit was intentionally omitted because current DOM requires AGNOS 19.6.16. The series replaces the earlier replay-style integration with focused native policy, lifecycle, diagnostics, and regression coverage.Vehicle
Architecture and safety boundaries
HONDA_ACCORDplatforms.Commit series
NATIVE-01 — native longitudinal behavior contract
Defines the Accord 11G longitudinal policy in
longitudinal_vehicle_tunes.pyand adds a dedicated regression contract.NATIVE-02 — planner envelope and projection
Integrates the Accord acceleration envelope and stable actuation-delay projection into DOM's native longitudinal planner without changing the default projection path.
NATIVE-03 — cruise and throttle policy
Integrates Accord-specific cruise acceleration limits and throttle permission behavior while preserving the existing DOM policy for all other vehicles.
NATIVE-04 — native MPC policy
Integrates the Accord lead extrapolation, follow, acceleration, and MPC behavior into the native longitudinal MPC implementation.
NATIVE-05 — native longitudinal control
Adds Accord-specific longitudinal state-transition and output policy to DOM's native longcontrol implementation, including stopping and starting behavior.
NATIVE-06 — native radar lead policy
Adds Accord 11G lead association, filtering, smoothing, stale-lead handling, and cut-in/cut-out behavior to the native radar process.
NATIVE-07 — native lateral and delay policy
Integrates Accord model-action scaling, lateral-delay behavior, model processing, controlsd policy, and lag estimation into the native DOM path.
NATIVE-08 — fixed PID gains
Prevents dynamic gain scaling from altering the Accord's validated fixed lateral PID gains.
NATIVE-09/10 — Honda lifecycle behavior
Adds the required LKAS HUD state-change pulse and moves learned Honda gas/wind persistence out of the real-time controller path.
NATIVE-11 — reverse-learning protection
Prevents learned delay and vehicle-parameter updates while the vehicle is reversing.
NATIVE-12 — bounded CAN-validity diagnostics
Adds bounded CAN parser diagnostics and Accord-only diagnostic context with parser and Honda regression coverage.
Current-DOM OS compatibility
The replay inherits current DOM's AGNOS 19.6.16 manifest and launch contract unchanged. The former LKG3-only AGNOS 19.6.13 compatibility commit was deliberately excluded from the PR replay; carrying it forward would have replaced current DOM boot/system images with an older OS contract.
NATIVE-13 — brake-to-gas handoff
Adapts the relevant behavior from MVL commit
314b3f16e14093db50648fc0dd2415de96babb19:0.02per controller update.This improves final brake release and avoids an abrupt brake-to-gas transition.
NATIVE-14 — expanded low-speed brake PID
Adapts the relevant behavior from MVL commit
83bf1f7295876c71b02baca839a37ff02e2f3c4f:0.001 m/s², rather than only requests below the oldmin_gascrossover.0.001 m/sand below3.0 m/s.This improves gentle final deceleration, creeping control, stop settling, and brake release.
Files and scope
The conflict-resolved current-DOM PR contains 23 files covering only the native Accord integration and its tests:
There are no Bluetooth, Galaxy, wheel-control, UI-streamer, or unrelated vehicle files in the DOM-targeted patch.
Host verification
Conflict-resolved current-DOM replay
5122b8df4231f5eba95207cee538a595eaac9259a7ea595e0a9e1e81335b22e7ded3902ca17229d5E501,F821,ISC002): passedThe two qualified controls failures are unrelated to this PR and reproduce current-DOM inconsistencies: the existing generic force-stop helper returns
0.20while its unchanged test expects0.32, and a newly added Genesis G70 assertion expects differing outputs for two inputs that the unchanged Genesis helper currently maps to the same value. The PR does not modify either failed helper or either failing assertion.Road-validated predecessor candidate
Candidate identity:
3bda5ad69a423ef7e286f0d3c03ae2cfd9b8ad9d37250b72e86d64ebb40de3cc3192c72e19f397e7bc9e0db578406bce21d0f589cdae492f25b2098ca2ffa68530b75fa120bf2a71e7f249ad5767cc8a350d31b9Earlier cumulative native validation
The NATIVE-01–12 stack was cumulatively verified and replayed onto the LKG-derived validation line. Focused verification included:
Road verification
The road evidence below applies to the behavior-equivalent predecessor stack ending at
3bda5ad69a423ef7e286f0d3c03ae2cfd9b8ad9d. The current-DOM replay preserves the NATIVE patches but has not yet been installed on the vehicle; the PR therefore remains a draft pending a short device boot/smoke check and proportionate road confirmation.NATIVE-01–12 baseline
NATIVE-01–12 were road validated on the LKG-derived native full-validation stack:
52c7e8160b9b67df5b1711dac92b8e071257a6b5accord11g-dom-native-full-road-validated-20260830NATIVE-13/14 final road validation
The NATIVE-13/14 candidate was tested across extended morning and evening driving, including the intended low-speed operating region.
Driver-observed validation included:
The low-speed changes behaved normally throughout the completed driving sessions. No behavior indicating a NATIVE-13/14 low-speed-control regression was observed.
Evening connector incident
One evening-drive interruption occurred after a physical harness/connector disturbance. Focused qlog evidence provides the following sequence; wall-clock times are reconstructed from tar-preserved qlog segment-close timestamps because the embedded qlog clock was stale:
canValid=false,canTimeout=true, cruise disabled, controls revoked, and PandarelayMalfunction.CAN Bus Disconnected: Likely Faulty Cable/canBusMissing/permanent.relayMalfunctionandsteerUnavailableremained latched; UI requested a vehicle restart.controlsAllowed=trueand cruise enabled.This is classified as a high-confidence external harness/connector CAN-path interruption:
The incident is therefore documented as an external validation anomaly, not a merge blocker or evidence of a NATIVE-13/14 regression.
Non-blocking observations
interruptRateCan2fault after reconnection. The system remained engageable and subsequently reachedcontrolsAllowed=true. This should be monitored on future clean boots and investigated separately if it recurs without connector movement.cruiseMismatchobservations occurred earlier in the route. They did not coincide with the CAN loss, did not prevent continued operation, and are not introduced by NATIVE-13/14.Validation evidence
Compact road-validation bundle
native14-final-road-validation-20260902-203808.tar.gz98fd0043cd0e86bcfa6df145c076e366d28ec81c97f7d0764661953970b57d03Full forensic collection
accord-log-hub-20260902-195324.tar.gz31d890e6483be49fcc6b5d7cc43fd6955a64a440cc4d6376837caaa397d864e6Focused incident qlogs
native14-incident-qlogs-20260902-1720-1815-20260902-212755.tar.gzb114cc4ad18a684c0d5f95ca555c0dae3a7ea1ceddc4633a03a636e1ffbe2fa80000006d--c77c455c320000006f--f5c3bdebf5Data-quality note: the selected qlogs contained a stale embedded wall clock reporting 28 July 2026. Selection used tar-preserved file modification times, and incident times are therefore approximate to the one-minute segment boundary. The raw qlogs remain intact. A first-pass summary decoder also stopped early on a structured radar/event wrapper in each qlog; this did not affect the CAN, Panda, controls, alert, and recovery transitions cited above.
The binary evidence bundles are retained outside the source branch and are available to maintainers on request. Their hashes are included here so transferred copies can be authenticated without adding large logs to the repository.
Known exclusions and follow-up work
The following remain intentionally excluded and will be evaluated separately:
agnos.jsonresolver changesReview request
This is a complete native Accord 11G integration rather than a generic DOM behavior change. Review should focus on:
Submission status
Merge conflicts are resolved and the current-DOM replay is host verified. GitHub reports the head as 13 commits ahead, 0 behind, and mergeable.
The NATIVE behavior is road validated on the preserved predecessor head
3bda5ad69a…. This PR remains a draft until the rebased heada7ea595e0a…receives a device boot/smoke check and proportionate road confirmation. The documented connector interruption remains non-blocking and is not attributed to this patch series.