Skip to content

[BHP1-1498] Tool/Calculator Validations#233

Open
rjsheperd wants to merge 2 commits into
mainfrom
rj-add-calculator-validations
Open

[BHP1-1498] Tool/Calculator Validations#233
rjsheperd wants to merge 2 commits into
mainfrom
rj-add-calculator-validations

Conversation

@rjsheperd
Copy link
Copy Markdown
Contributor

Purpose

Disable calculator compute when inputs are outside min/max bounds or empty. Shows inline error and range placeholder (e.g. 1 - 60). Bounds convert automatically with English/Metric toggle.

Related Issues

Closes BHP1-1498

Submission Checklist

  • Included Jira issue in the PR title (e.g. BHP1-### <title>)
  • Code passes linter rules (clj-kondo --lint components/**/src bases/**/src projects/**/src)
  • Feature(s) work when compiled (clojure -M:compile-cljs)

Testing

  1. Run migration migrations.2026-05-18-set-calculator-variable-min-max
  2. Open Probability of Ignition calculator
  3. Enter 999 for Air Temperature — error appears, Compute disabled
  4. Toggle to Metric — error bounds update (e.g. -40 - 48)
  5. Enter a valid value — Compute enables, calculator works normally
  6. Leave an input empty — Compute stays disabled

Screenshots

CleanShot 2026-05-18 at 15 40 01

@Kcheung42
Copy link
Copy Markdown
Collaborator

Kcheung42 commented May 22, 2026

I'm noticing when I change the units for an input, the place holder and error message is not updating accordingly, i.e. changing temperature from F -> C, the 120 value stored in the vms should have changed to ~48

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants