Improve discoverability of downloading a local profile#6216
Draft
fatadel wants to merge 1 commit into
Draft
Conversation
fatadel
requested review from
a team,
canova and
mstange
and removed request for
a team and
mstange
July 24, 2026 12:20
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6216 +/- ##
==========================================
- Coverage 83.63% 83.60% -0.04%
==========================================
Files 346 346
Lines 37179 37195 +16
Branches 10418 10428 +10
==========================================
+ Hits 31095 31097 +2
- Misses 5656 5670 +14
Partials 428 428 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The profile menu was labeled "Upload Local Profile" with an upload icon, so the Download button tucked inside its dialog was easy to miss for users who just wanted to save a profile to disk. Rename the menu button to "Save This Profile…" and give it a save icon. In the panel, present the Download and Upload actions as two destination cards instead of a pair of buttons, and add an "applies to both" badge to the include-options heading to make clear those choices affect either destination. The upload card reads "Re-upload" when the profile is already published. Closes firefox-devtools#3620
flodolo
reviewed
Jul 24, 2026
| MenuButtons--publish--save-profile-title = Save This Profile | ||
| MenuButtons--publish--save-profile-description = Pick what to include, then choose a destination below. | ||
| # Refers to the two destinations offered in this panel: downloading the profile to a file and uploading it to share. | ||
| MenuButtons--publish--applies-to-both = applies to both |
Contributor
There was a problem hiding this comment.
This is not a very friendly design for localization. Please don't use a badge for this type of information, it should be explained in the text.
fatadel
marked this pull request as draft
July 24, 2026 15:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main | Deploy preview
The profile menu was labeled "Upload Local Profile" with an upload icon, so the Download button tucked inside its dialog was easy to miss for users who just wanted to save a profile to disk.
Rename the menu button to "Save This Profile…" and give it a save icon. In the panel, present the Download and Upload actions as two destination cards instead of a pair of buttons, and add an "applies to both" badge to the include-options heading to make clear those choices affect either destination. The upload card reads "Re-upload" when the profile is already published.
Closes #3620
Profile
This is how it looks like.