Create the IPC track from the timeline-ipc schema display location#6213
Open
fatadel wants to merge 1 commit into
Open
Create the IPC track from the timeline-ipc schema display location#6213fatadel wants to merge 1 commit into
fatadel wants to merge 1 commit into
Conversation
The IPC timeline track was added whenever a thread had a marker with data.type === 'IPC', even though the markers shown inside that track were already selected via the timeline-ipc marker-schema display location. Drive track creation from that same display location so the two agree, and so IPC handling no longer hardcodes the payload type. The combined (front-end + Gecko) schema list is used so the front-end IPC schema override always contributes its timeline-ipc location. Part of firefox-devtools#6194
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6213 +/- ##
========================================
Coverage 83.63% 83.63%
========================================
Files 346 346
Lines 37174 37183 +9
Branches 10318 10424 +106
========================================
+ Hits 31090 31099 +9
Misses 5656 5656
Partials 428 428 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Profile with IPC messages enabled:
Main | Deploy preview
The IPC timeline track was added whenever a thread had a marker with data.type === 'IPC', even though the markers shown inside that track were already selected via the timeline-ipc marker-schema display location. Drive track creation from that same display location so the two agree, and so IPC handling no longer hardcodes the payload type.
The combined (front-end + Gecko) schema list is used so the front-end IPC schema override always contributes its timeline-ipc location.
Part of #6194