Fix label selector + add PDB (firefly-iii/firefly-iii#12313)#114
Merged
JC5 merged 6 commits intoJun 1, 2026
Conversation
Member
|
Nice work once again! |
Contributor
Author
|
I'm currently migrating my deployment files to the Helm chart and keep finding small issues here and there, so there might be a few more follow-up MRs 😄 |
Member
|
That's quite alright. I know nothing about kubernetes so all support is welcome. 😁 |
Merged
wrenix
reviewed
Jun 2, 2026
| Selector labels for the app pods | ||
| */}} | ||
| {{- define "firefly-iii.appSelectorLabels" -}} | ||
| {{ include "firefly-iii.selectorLabels" . }} |
Contributor
There was a problem hiding this comment.
This was a breaking-change for a running kubernetes-deployment.
So the helm-chart should have an Major-Version increment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue firefly-iii/firefly-iii#12313 and adds an option to create a PodDisruptionBudget.