New method for calculating vorticity diagnostic#734
Open
tommbendall wants to merge 4 commits into
Open
Conversation
jshipton
reviewed
May 5, 2026
| if self.space is None or not is_cg(self.space): | ||
| # Using DG, calculate u in HCurl space as intermediary | ||
| self.hcurl_intermediary = True | ||
| assert self.method != 'solve', ( |
Contributor
There was a problem hiding this comment.
This assertion is causing test failures... I'm not quite sure what you intend here...
Contributor
Author
There was a problem hiding this comment.
Interesting... I wonder if that actually might explain a real problem with the vorticity diagnosics!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements a new method for calculating vorticity diagnostics for shallow-water equations.
We currently solve a linear variational problem to evaluate the vorticity in H1 from the velocity in HDiv, which is equivalent to the "weak curl". I am wondering if this can give very noisy results on the cubed-sphere...
... so this PR implements a different method, which first projects the velocity into HCurl, and then interpolates the "strong curl" of that velocity into a DG space.