DO NOT SQUASH Connorjward/merge release#5134
Merged
Merged
Conversation
* Make some env settings global * Remove unnecessary job steps * Improve readability via comments etc Partial step towards being able to test more configurations efficiently.
I found that this is needed to build h5py if we are using a PETSc-built HDF5. https://docs.h5py.org/en/stable/build.html#building-against-parallel-hdf5
* Enable setting the base for a PR using labels Helpful for multi-PR changes.
* Fix DualSpace + RestrictedFunctionSpace * Fix RestrictedFunctionSpace + RestrictedFunctionSpace * Fix ASMStarPC + Restricted VectorFunctionSpace
As discussed in https://github.com/firedrakeproject/firedrake/wiki/Firedrake-meeting-2026-05-12#cw-testing-configurations we need a better strategy for testing more builds of Firedrake. The basic idea is: For pull requests and pushes we always test the default configuration of Firedrake in full If a PR is labelled ci:complex, ci:cuda, ci:macos then we run the full test suite on that configuration Whenever we push to main or release we build and test all configurations but we only test a portion of the extra configurations.
Basically just fixing shell escape issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description