Leo/nested interpolate#5097
Draft
leo-collins wants to merge 2 commits into
Draft
Conversation
pbrubeck
reviewed
May 12, 2026
Comment on lines
+186
to
+188
| lowered_operand = NestedInterpolateLowerer()(operand) | ||
| if lowered_operand is not operand: | ||
| return get_interpolator(self._ufl_expr_reconstruct_(lowered_operand)) |
Contributor
There was a problem hiding this comment.
Wouldn't this approach freeze the nested expression? What if we change the numeric values between different calls to assemble on the same expression?
pbrubeck
reviewed
May 12, 2026
| @DAGTraverser.postorder | ||
| def _(self, o: UFLInterpolate, operand: Expr) -> Expr: | ||
| from firedrake.assemble import assemble | ||
| return as_ufl(assemble(o._ufl_expr_reconstruct_(operand))) |
Contributor
There was a problem hiding this comment.
Isn't BaseFormAssembler the intended way of traversing the DAG for assemble?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.