Skip to content

Drop the ecdsa_preprocessing_data destructor (UB + heap leak) #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kozyilmaz wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Drop the ecdsa_preprocessing_data destructor (UB + heap leak) #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/cosigner/cmp_ecdsa_signing_service.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ struct ecdsa_preprocessing_data
byte_vector_t mta_request;
std::map<uint64_t, byte_vector_t> G_proofs;
std::map<uint64_t, ecdsa_signing_public_data> public_data;
~ecdsa_preprocessing_data() {OPENSSL_cleanse(k.data, sizeof(ecdsa_preprocessing_data));}
// No destructor: scalar members self-wipe; a whole-struct cleanse here is UB + leak.
};

// this class holds the common functionality for cmp_ecdsa_online_signing_service and cmp_ecdsa_offline_signing_service
Expand Down