feat: safe triangles#793
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new safetriangles Attribute package to generate “safe triangle” hover zones between a trigger and a target (intended to keep context menus open while moving the pointer), and wires it into the main Attributes loader.
Changes:
- Introduces
@finsweet/attributes-safetrianglespackage (init, selector helpers, constants, factory logic, README, tsconfig). - Registers the new attribute in the central loader (
packages/attributes/src/load.ts) and dependencies. - Updates
pnpm-lock.yaml(including adding the workspace package and bumpingesbuild).
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Adds the new workspace package and updates lockfile dependencies (incl. esbuild). |
| packages/utils/src/constants/attributes.ts | Adds a new exported attribute key constant for safetriangles. |
| packages/safetriangles/tsconfig.json | Adds package TS config extending the repo base. |
| packages/safetriangles/src/utils/selectors.ts | Adds generated selector helpers for the new attribute. |
| packages/safetriangles/src/utils/constants.ts | Defines element keys and settings (delay, debug). |
| packages/safetriangles/src/init.ts | Initializes safe triangles for each trigger/target pair. |
| packages/safetriangles/src/index.ts | Exports version, init, ELEMENTS, and SETTINGS. |
| packages/safetriangles/src/factory.ts | Implements SVG/path-based safe triangle behavior and lifecycle/cleanup. |
| packages/safetriangles/README.md | Adds usage/API access documentation for the new attribute. |
| packages/safetriangles/package.json | Adds the new workspace package manifest. |
| packages/attributes/src/load.ts | Adds dynamic import case for safetriangles. |
| packages/attributes/package.json | Adds dependency on @finsweet/attributes-safetriangles. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As inspired by https://www.smashingmagazine.com/2023/08/better-context-menus-safe-triangles/