fix: add space to allocate and accept args#38
Merged
Conversation
frrist
approved these changes
Jun 15, 2026
Peeja
approved these changes
Jun 15, 2026
alanshaw
added a commit
to fil-forge/sprue
that referenced
this pull request
Jun 19, 2026
) This is part of reverting the change to send allocate and accept delegations from the client. We decided this should in fact be made with the storage provider as the subject and that the upload service should be pre-authorized by the storage provider to invoke. This PR: * Updates the storage provider store to store proofs per provider. * Adds a proofs arg to the `sprue admin provider register` CLI command. * Uses proofs from the store instead of the invocation when invoking `/blob/allocate` or `/blob/accept`. * Adds some additional validation to the provider registration handler to ensure required proofs are provided. Depends on: * fil-forge/libforge#38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add space as argument to
/blob/allocateand/blob/accept.This is part of reverting the change to send allocate and accept delegations from the client. We decided this should in fact be made with the storage provider as the subject and that the upload service should be pre-authorized by the storage provider to invoke.