feat: Attested Signatures + UCAN Principal Clarification#37
Merged
Conversation
Add `go-workspace-test.yml`, a reusable (workflow_call) workflow that tests a repo against its fil-forge sibling repos' matching branches, plus a thin caller. When a PR's branch name also exists on a sibling repo this module depends on (coordinated change sets share a branch name), the workflow clones those matching-branch siblings, synthesizes a go.work over them, and runs the repo's own `make test` against the integrated workspace. The matching repos appear in the check name on the PR. When no sibling has a matching branch, the test job is skipped — the normal per-repo go-test.yml already covers that case. This is informational feedback, not a merge gate: go.mod stays on the published sibling versions until they land, so go-test.yml remains the real blocker. The job is not posted as a status and should not be a required check. libforge hosts the reusable workflow; sibling repos call it at @v1. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
alanshaw
approved these changes
Jun 17, 2026
| // fetch an attestation for it, and fail if it cannot. The authority parameter | ||
| // is the DID of the service we trust to be issuing attestations. | ||
| ProofAttestations(ctx context.Context, proofs []ucan.Delegation, authority did.DID) ([]ucan.Invocation, error) | ||
| // ProofAttestations(ctx context.Context, proofs []ucan.Delegation, authority did.DID) ([]ucan.Invocation, error) |
| require.Nil(t, attestations) | ||
| }) | ||
| } | ||
| // func TestContainerProofStore_ProofAttestations(t *testing.T) { |
Peeja
force-pushed
the
petra/feat/attested-signatures
branch
from
c3b917b to
e10c6a2
Compare
* `multikey` and `absentee` go up a level to the root. * `verification.NewIssuer()` is gone; we can use `multikey.NewIssuer()` in every case we have. * The verifier factory types move `validator`. They're not inherent to *validation*, they're just used to configure the validator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See fil-forge/ucantone#30