Skip to content

feat: Remove ProofAttestations from proof store #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Peeja wants to merge 1 commit into from
+4 −372
Closed

feat: Remove ProofAttestations from proof store #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions didmailto/did.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@ func Email(d did.DID) (string, error) {
return fmt.Sprintf("%s@%s", emailLocal, domain), nil
}

// Parse parses a mailto DID from a string. This is the same as [did.Parse],
// with validation that the DID is a mailto DID.
func Parse(str string) (did.DID, error) {
d, err := did.Parse(str)
if err != nil {
Expand Down
58 changes: 0 additions & 58 deletions ucan/attestations.go
View file
Open in desktop

This file was deleted.

183 changes: 0 additions & 183 deletions ucan/attestations_test.go
View file
Open in desktop

This file was deleted.

26 changes: 2 additions & 24 deletions ucan/proof_store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,18 +17,15 @@ type ProofStore interface {
// in strict sequence where the aud of the previous Delegation matches the iss
// of the next Delegation.
ProofChain(ctx context.Context, aud did.DID, cmd ucan.Command, sub did.DID) ([]ucan.Delegation, []cid.Cid, error)
// ProofAttestations returns a list of attestations for proofs that need them.
// i.e. if a proof is signed with a non-standard signature this function will
// fetch an attestation for it, and fail if it cannot. The authority parameter
// is the DID of the service we trust to be issuing attestations.
ProofAttestations(ctx context.Context, proofs []ucan.Delegation, authority did.DID) ([]ucan.Invocation, error)
}

// ContainerProofStore is a proof store backed by an in-memory container.
type ContainerProofStore struct {
container ucan.Container
}

var _ ProofStore = (*ContainerProofStore)(nil)

// NewContainerProofStore creates a proof store backed by an in-memory container.
func NewContainerProofStore(ct ucan.Container) *ContainerProofStore {
return &ContainerProofStore{container: ct}
Expand All @@ -38,10 +35,6 @@ func (cps *ContainerProofStore) ProofChain(ctx context.Context, aud did.DID, cmd
return ProofChain(ctx, cps.matchDelegations, aud, cmd, sub)
}

func (cps *ContainerProofStore) ProofAttestations(ctx context.Context, proofs []ucan.Delegation, authority did.DID) ([]ucan.Invocation, error) {
return ProofAttestations(ctx, cps.listInvocations, proofs, authority)
}

func (ps *ContainerProofStore) listDelegations(ctx context.Context, aud did.DID, cmd ucan.Command, sub did.DID) iter.Seq2[ucan.Delegation, error] {
return func(yield func(ucan.Delegation, error) bool) {
if ps.container == nil {
Expand All @@ -60,18 +53,3 @@ func (ps *ContainerProofStore) listDelegations(ctx context.Context, aud did.DID,
func (ps *ContainerProofStore) matchDelegations(ctx context.Context, aud did.DID, cmd ucan.Command, sub did.DID) iter.Seq2[ucan.Delegation, error] {
return NewDelegationMatcher(ps.listDelegations)(ctx, aud, cmd, sub)
}

func (ps *ContainerProofStore) listInvocations(ctx context.Context, aud did.DID, cmd ucan.Command, sub did.DID) iter.Seq2[ucan.Invocation, error] {
return func(yield func(ucan.Invocation, error) bool) {
if ps.container == nil {
return
}
for _, d := range ps.container.Invocations() {
if d.Audience() == aud && d.Command() == cmd && d.Subject() == sub {
if !yield(d, nil) {
return
}
}
}
}
}
Loading
Loading