docs(fep): QuantPub rev 6 — pre-submission consistency fixes (#905) - #1039
Merged
Conversation
…905) Batches the #1038 review's pre-submission nits: - Motivation no longer claims a vendor-prefixed aurboda: variant (the quant: vocabulary ships on the wire since #1034); timeline-enrich.ts header likewise updated (also ticks the first #1037 box). - docs/fep/README.md indexes the reddit draft and marks it as not-a-FEP. - Reddit draft: routes aren't 'static' (the series endpoint authorizes), no-store scoped precisely (discovery doc is cacheable), and the running-code claim (workouts) separated from the spec claim (any observation). Consumer-side structuredUrl token fallback noted on #1037 (code follow-up). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016VFPcqXTu9DPuARhRBnBoo
fiddur
marked this pull request as ready for review
August 20, 2026 09:19
fiddur
commented
Aug 20, 2026
fiddur
left a comment
Owner
Author
There was a problem hiding this comment.
✅ Approved
Docs-only change plus one doc-comment rewrite; no behavior changes. I verified each claim the diff makes against the code:
timeline-enrich.ts: the new header is accurate —quant-extension.tsdoes put the scalar summaries in-band (quant:metrics) whilequant:seriescarries only links, so "scalar summary in-band, not the high-resolution series" is right, and the fetch path (api_base+/public/{user}/feed/{postId}, matched byFEED_OBJECT_PATH) is indeed the §7 id-convention shape. The old text ("Fedify's typed vocab drops theaurboda:extension") was genuinely stale after #896, so this is a real fix rather than comment churn.quantpub-reddit-draft.md:no-storeon every data response / discovery-only caching matches §8.4 and §4; dropping "static" from "two-and-a-half static routes" matches the weekend section (only the discovery doc is static); and narrowing "my workouts and sleep observations are ActivityPub posts" to workouts matches what Aurboda actually federates today.quantpub.md: thequant:wire-vocabulary claim matches the Implementations section andquant-extension.ts.docs/fep/README.md: the new entry correctly labels the draft as not-a-FEP.
Nothing blocking. Approving.
Non-blocking — fold into a later PR, don't re-roll this one
docs/fep/quantpub-reddit-draft.md:17: the rewritten sentence leaves one ~110-col line in a file otherwise wrapped at ~80. Also, the new parenthetical "(and the spec covers any observation — sleep, HRV, steps, mood, …)" now largely duplicates the later privacy-list bullet "It's not just exercise: a genericObservationshape covers sleep, HRV, steps, mood, glucose"; one of the two could go.docs/fep/quantpub.mdImplementations (outside this diff): the parenthetical says the remaining vendor surface is "the/.well-known/aurbodadocument backs Aurboda-specific challenge federation", but the Level 3 enrichment path also uses it —realEnrichDepswiresdiscover: discoverInstance, which fetches/.well-known/aurboda(challenge-federation.ts:72), not §4's/.well-known/quantpub. So the shipped ingest resolvesapi_basefrom the vendor document rather than the spec one. Since the PR's theme is pre-submission accuracy, that's worth reconciling before FEP submission — either pointdiscoverInstance/enrichment at/.well-known/quantpub(it is already served,well-known-router.ts:73) or soften the Implementations wording.
This was referenced Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #905 (does not close it). Batches the non-blocking items from the #1038 review, per the reviewer's note to fold them in before upstream submission:
aurboda:) variant" — thequant:vocabulary is on the wire since feat(feed): federate the QuantPub quant:Exercise extension + serve its @context (#896) #1034. Same stale wording fixed in thetimeline-enrich.tsheader (also the first checkbox of QuantPub extension polish (deferred review nits from #1034) #1037).docs/fep/README.mdnow indexesquantpub-reddit-draft.mdand states it is not itself a FEP.no-storeeverywhere" →no-storeon data responses with the cacheable discovery doc called out; workouts-are-running-code vs any-observation-is-spec claims separated.quant:structuredUrltoken fallback) recorded on QuantPub extension polish (deferred review nits from #1034) #1037 as a code follow-up rather than changed here.Backend
pnpm checkgreen (comment-only code change).🤖 Generated with Claude Code
https://claude.ai/code/session_016VFPcqXTu9DPuARhRBnBoo