fix: skip async invoke self-cancel on own done.invoke#627
Merged
Conversation
Owner
|
Hi @loRes228 , how are you? Thanks for pointing out and the fix. Can you please add a regression test that reproduces the issue? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #627 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 42 42
Lines 4976 4976
Branches 812 812
=========================================
Hits 4976 4976
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
Hi, ofc |
|
fgmacedo
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



On the async engine, when a state exits on its own
done.invoke,InvokeManager._cancelcalls
invocation.task.cancel()unconditionally — but that task is the current taskand the machine gets stuck.
The sync branch already handles exactly this (step 4 skips the join when
invocation.thread is not threading.current_thread()— "skip if we ARE that thread").The async branch just missed the symmetric guard. This adds it: