Skip to content

Refresh time-balanced shard timings for Core and Browser suites - #134

Merged
fgilio merged 4 commits into
mainfrom
claude/project-handoff-prep-hdfvjt
Jul 7, 2026
Merged

Refresh time-balanced shard timings for Core and Browser suites#134
fgilio merged 4 commits into
mainfrom
claude/project-handoff-prep-hdfvjt

Conversation

@fgilio

@fgilio fgilio commented Jul 7, 2026

Copy link
Copy Markdown
Owner

The committed shards.json only covered 28 test classes from PR #102,
so every sharded CI run warned it was out of date and fell back to
stale balancing. Regenerated via --update-shards across both suites:
204 classes with fresh timings.

Co-Authored-By: Claude Fable 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01HVdCTd166nSKuhBsnKePM9

Summary by CodeRabbit

  • Chores
    • Updated development dependencies to use the newer Laravel PAO package version.
    • Refreshed test timing metadata to match the current test suite.
  • Tests
    • Adjusted a Livewire-related test to better align with configured payload limits, improving coverage for large component sets.

claude added 4 commits July 7, 2026 11:15
The committed shards.json only covered 28 test classes from PR #102,
so every sharded CI run warned it was out of date and fell back to
stale balancing. Regenerated via --update-shards across both suites:
204 classes with fresh timings.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HVdCTd166nSKuhBsnKePM9
composer audit reported 19 advisories across 10 packages (laravel/framework,
guzzle, several symfony components). All fixes were patch/minor bumps within
existing constraints, so this is a lock-only update; composer audit is now
clean.

Livewire 4.3 raised the default payload.max_components from 20 to 200, which
broke the lazy-load isolation test's hardcoded 25-file setup. The test now
derives its file count from the config value so it keeps exceeding the limit
it exists to exercise.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HVdCTd166nSKuhBsnKePM9
Composer flags nunomaduro/pao as abandoned in favor of laravel/pao. The swap
also replaces its transitive shipfastlabs/agent-detector with the maintained
laravel/agent-detector, so composer audit no longer reports any abandoned
packages.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HVdCTd166nSKuhBsnKePM9
npm audit reported two high-severity advisories in ws (uninitialized memory
disclosure, memory-exhaustion DoS). Lock-only update via npm audit fix plus
minor in-range bumps; audit is now clean and Vitest suite and CSS build pass.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HVdCTd166nSKuhBsnKePM9
@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

An error occurred during the review process. Please try again later.

📝 Walkthrough

Walkthrough

Swapped the nunomaduro/pao dev dependency for laravel/pao in composer.json, refreshed Pest shard timing data and checksum metadata in shards.json, and updated a Livewire test to derive fixture size and assertions from the configured livewire.payload.max_components value instead of a hardcoded number.

Changes

Dependency and test maintenance

Layer / File(s) Summary
Dev dependency swap
composer.json
nunomaduro/pao replaced with laravel/pao in require-dev.
Pest shard timing refresh
tests/.pest/shards.json
Timing data expanded to cover Arch, Feature, and Unit test classes; checksum and updated_at metadata refreshed.
Config-driven lazy-load test
tests/Unit/Livewire/ReviewPageTest.php
Test now reads max_components from config to size its fixture and validate the lazy-load assertion, replacing a hardcoded value.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

  • fgilio/rfa#57: Updates Pest browser shard configuration, related to the shard timing data changed here.
  • fgilio/rfa#59: Changes CI to run Pest across parallel shards, tied to the same shard timing metadata updated in this PR.

Poem

A rabbit hopped through composer's lock,
Swapped one pao for another, tick-tock.
Shards got timed, fresh and neat,
A test now bends to config's beat.
No web, no auth, just local cheer —
Desktop bunny, review's clear! 🐇


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@fgilio
fgilio merged commit ca01d09 into main Jul 7, 2026
15 checks passed
@fgilio
fgilio deleted the claude/project-handoff-prep-hdfvjt branch July 7, 2026 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants